Hi,
The webrev:
http://cr.openjdk.java.net/~andrew/zero/webrev.04/
extends the build changes added as part of the Zero assembler port to
also support the alpha architecture. This has been used in IcedTea6
since July 2008.
The change to ARCH is necessary so we don't get -Dalpha which
conflicts
Basic change seems harmless to me, the _ARCH_ definition is a little
concerning, do we need
that definition for all arch's or just alpha?
I hate to pollute this already overpopulated arch naming mess. :^(
How about:
CPP_ARCH_FLAGS = -DARCH='"$(ARCH)"'
# Alpha arch does not like "alpha" defined
Changeset: fb56f86642d6
Author:andrew
Date: 2010-06-03 18:49 +0100
URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/fb56f86642d6
6958257: Add support for alpha
Summary: Allow the Zero port to be built on alpha architectures
Reviewed-by: ohair
! make/common/Defs-linux.gmk
On 3 June 2010 18:36, Kelly O'Hair wrote:
> Basic change seems harmless to me, the _ARCH_ definition is a little
> concerning, do we need
> that definition for all arch's or just alpha?
> I hate to pollute this already overpopulated arch naming mess. :^(
>
> How about:
>
> CPP_ARCH_FLAGS = -DARCH=
Changeset: 2657ee0d2d14
Author:andrew
Date: 2010-06-03 19:37 +0100
URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/2657ee0d2d14
6958257: Add support for alpha
Summary: Allow the Zero port to be built on alpha architectures
Reviewed-by: ohair
! make/common/Defs-linux.gmk
Andrew John Hughes wrote:
:
Thanks Kelly. Your change does make more sense, especially given we
don't yet use the _alpha_ define anyway. I've pushed the revised
version:
http://hg.openjdk.java.net/jdk7/build/corba/rev/2657ee0d2d14
http://hg.openjdk.java.net/jdk7/build/jdk/rev/fb56f86642d6
Tha
On Jun 3, 2010, at 1:12 PM, Alan Bateman wrote:
Andrew John Hughes wrote:
:
Thanks Kelly. Your change does make more sense, especially given we
don't yet use the _alpha_ define anyway. I've pushed the revised
version:
http://hg.openjdk.java.net/jdk7/build/corba/rev/2657ee0d2d14
http://hg.op
On 3 June 2010 21:12, Alan Bateman wrote:
> Andrew John Hughes wrote:
>>
>> :
>> Thanks Kelly. Your change does make more sense, especially given we
>> don't yet use the _alpha_ define anyway. I've pushed the revised
>> version:
>>
>> http://hg.openjdk.java.net/jdk7/build/corba/rev/2657ee0d2d14
Andrew John Hughes wrote:
On 3 June 2010 21:12, Alan Bateman wrote:
Andrew John Hughes wrote:
:
Thanks Kelly. Your change does make more sense, especially given we
don't yet use the _alpha_ define anyway. I've pushed the revised
version:
http://hg.openjdk.java.net/jdk7/build/corba/r
