Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

2012-02-09 Thread Erik Joelsson
On 2012-02-09 03:51, David Holmes wrote: make/defs.make: + ifneq (,$(SPEC)) + include $(SPEC) + endif Having the blank first looks odd. I assume you aren't using -inlcude because you want to see errors if SPEC is set but not found. I guess it's an unconscious habit from java where you rat

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

2012-02-09 Thread Erik Joelsson
New webrev: http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg Changes since last time: * Moved the , to after $(SPEC) * Changed comment in gcc/sparcWorks.make according to suggesti

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

2012-02-09 Thread Fredrik Öhrström
Looks good! //Fredrik - erik.joels...@oracle.com skrev: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

2012-02-09 Thread David Holmes
Added back runtime to the cc list On 9/02/2012 7:33 PM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg Changes since last time: * Moved the , to

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

2012-02-09 Thread Kelly O'Hair
The only issue I see is that it's using cygpath -m -a and not cygpath -s -m -a which I think means that the path could have spaces in it. Otherwise, looks fine. -kto On Feb 9, 2012, at 1:33 AM, Erik Joelsson wrote: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ >

Re: Is anyone able to build on Win 7

2012-02-09 Thread Kelly O'Hair
Does this article provide any help: https://kc.mcafee.com/corporate/index?page=content&id=KB55075&actp=search&viewlocale=en_US&searchid=1328818133782 It suggests that rebase'ing the CYGWIN DLL's will help. Seems a bit strange to me, just passing it on. -kto On Jan 25, 2012, at 5:10 PM, Pete B

Re: RFR 7142950: jdk7u cannot bootstrap Mac OS build [macosx]

2012-02-09 Thread Michael McMahon
Hi, http://cr.openjdk.java.net/~michaelm/7142950/jdk/webrev.2/ This is an updated webrev based on the contribution/suggestion from Scott Kovatch. It changes the build image directories on Mac, to have the same format/directory structure as the other platforms (ie. it removes the Contents/Home

Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable

2012-02-09 Thread John Coomes
Erik Joelsson (erik.joels...@oracle.com) wrote: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to after $(SPEC)