Re: RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx]

2012-03-16 Thread Fredrik Öhrström
2012-03-15 21:56, Kelly O'Hair skrev: > It is very hard to know the complete impact of building the product in > different locales when > native code is involved. So as much as I would like to guarantee all > selections will work, I would > rather we narrow down the options here to avoid having t

Re: Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

2012-03-16 Thread Erik Joelsson
http://cr.openjdk.java.net/~erikj/7141246/webrev.03/ Removed all references to "minimal". Also cleaned up the defaults section a bit. /Erik On 2012-03-14 09:17, Erik Joelsson wrote: On 2012-03-14 06:00, David Holmes wrote: Hi Erik,

Re: RFR (M): Enable OpenJDK builds on Windows with MinGW/MSYS

2012-03-16 Thread Volker Simonis
Hi Jonathan, you're right, I havn't looked at the tests until now - just wanted to get the build up and running. My only concerns so far are the few tests which require a Korn Shell as I think there's no ksh available for MinGW/Msys. But I promise to look at it. By the way, has anybody ever suc

code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-16 Thread Daniel D. Daugherty
Greetings, I need code reviews for some Makefile and packaging changes. Wait, come back! They're not that scary... These are Full Debug Symbols changes... so maybe they are that scary... These changes have gone through two rounds of internal review. The following bugs are being used to revamp

Re: Please review a new script for JDK8: JDK source code legal headers conformance verification

2012-03-16 Thread Joseph Darcy
Hi Misha, I think including this kind of script in the JDK is a great idea. Follow-up work could include adding a script that would use this first script to verify the source files had the expected license. Such a check could be a make target run as part of the build. Cheers, -Joe On 3/5/