Looks good.
Since the annotation is a compile time only annotation, it should not
affect any future modularization efforts. Right Alan?
//Fredrik
2012/5/23 Kelly O'Hair :
>
> 7170969: Add @GenerateNativeHeader to classes whose fields need to be
> exported for JNI
> http://cr.openjdk.java.net/~
Kelly,
Can you hold off pushing this for a few days? While this is compile-time
only dependency I think the impact needs further study.
-Alan.
On 23/05/2012 02:14, Kelly O'Hair wrote:
7170969: Add @GenerateNativeHeader to classes whose fields need to be exported
for JNI
http://cr.openjdk.j
On 2012-05-22 23:08, Kelly O'Hair wrote:
Not sure where we are on these changes. I have made sure that they don't
regress the old builds
and am ready to integrate, but I'm concerned on Alan's modularity comment, and
also who should
I be adding to the "Reviewed-by" list.
I'm also not sure if A
There is no point holding off this push since GenerateNativeHeader annotation
and uses of it were already pushed long time ago. These are just the finishing
touches to cater for the conversion of the remaining makefiles.
If you want another location for the annotation then we can easily search and
On 23/05/2012 08:30, Erik Joelsson wrote:
I'm also not sure if Alan's comment was a blocker. The idea with
GenerateNativeHeader was approved by Jon Gibbon's initially at least.
Alan?
I don't like holding things up but I do think this needs wider
consideration.
-Alan
On 2012-05-23 09:51, Fredrik Öhrström wrote:
There is no point holding off this push since GenerateNativeHeader annotation
and uses of it were already pushed long time ago. These are just the finishing
touches to cater for the conversion of the remaining makefiles.
I think Fredrik has a point her
At present, the building of ExtensionSubtables.cpp produces a warning:
../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31:
warning: dereferencing type-punned pointer will break strict-aliasing rules
[-Wstrict-aliasing]
due to this code:
// read a 32-bit value that might only
- Original Message -
>
>
>
>
> On Tue, May 15, 2012 at 4:35 AM, David Holmes <
> [email protected] > wrote:
>
>
> Hi Pierre,
>
> [...]
>
> This is bug 7150392 and was fixed about 6 weeks ago.
>
>
>
> Hi David
>
>
> Indeed, it's exactly the same problem as bug #7150392
>
On 05/23/2012 01:00 AM, Alan Bateman wrote:
On 23/05/2012 08:30, Erik Joelsson wrote:
I'm also not sure if Alan's comment was a blocker. The idea with
GenerateNativeHeader was approved by Jon Gibbon's initially at least.
Alan?
I don't like holding things up but I do think this needs wider
co
I suppose the problem that some new version of GCC enables this option
by default and
we could run into a problem at run time if we don't disable it ?
But this patch would appear to disable it for the whole ICU library ..
and any other C++ code in the .so
which I would have to suppose impacts t
It may not be easy but its worth investigating.
BTW .. I have not recently tried the new build mechanism, but does anyone
on the build list know what kinds of build changes will very probably
just work
with that too, and which will need to be tested separately ?
-phil.
On 5/23/2012 9:12 AM, D
- Original Message -
> I suppose the problem that some new version of GCC enables this
> option
> by default and
> we could run into a problem at run time if we don't disable it ?
>
Yes, 4.4 to be precise. It's not particularly new; it came out on
April 21st, 2009.
> But this patch wo
- Original Message -
>
>
> - Original Message -
> > I suppose the problem that some new version of GCC enables this
> > option
> > by default and
> > we could run into a problem at run time if we don't disable it ?
> >
>
> Yes, 4.4 to be precise. It's not particularly new; it
On 5/23/2012 9:32 AM, Andrew Hughes wrote:
- Original Message -
I suppose the problem that some new version of GCC enables this
option
by default and
we could run into a problem at run time if we don't disable it ?
Yes, 4.4 to be precise. It's not particularly new; it came out on
Apr
Has anyone tried creating an unused native method declaration in the class to
trigger the native header
generation? public native void GenerateNativeHeader(); ??? Is that too
ugly?
-kto
On May 23, 2012, at 8:01 AM, Jonathan Gibbons wrote:
> On 05/23/2012 01:00 AM, Alan Bateman wrote:
>> O
On May 23, 2012, at 9:32 AM, Andrew Hughes wrote:
> Yes, I thought the same. But I don't see how you can direct flags to
> one specific file in the Makefiles. Any ideas?
You can add something like this to CFLAGS:
CFLAGS += $(CFLAGS_$(@F))
Then:
CFLAGS_foobar.o = -someoptions
-kto
On 23/05/2012 17:50, Kelly O'Hair wrote:
Has anyone tried creating an unused native method declaration in the class to
trigger the native header
generation? public native void GenerateNativeHeader(); ??? Is that too
ugly?
-kto
As Jon put it, for the classes in the base module, "we are del
- Original Message -
>
>
>
> On May 23, 2012, at 9:32 AM, Andrew Hughes wrote:
>
>
> Yes, I thought the same. But I don't see how you can direct flags to
> one specific file in the Makefiles. Any ideas?
>
> You can add something like this to CFLAGS:
> CFLAGS += $(CFLAGS_$(@F))
>
>
I wanted to be able to declare fields as native, but that was deemed
unacceptable.
-- Jon
On 05/23/2012 10:05 AM, Alan Bateman wrote:
On 23/05/2012 17:50, Kelly O'Hair wrote:
Has anyone tried creating an unused native method declaration in the
class to trigger the native header
generation?
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
corrupts the SUNW_* sections on objects. This has caused dtrace test
failures and Monitoring & Management test failures. The gobjcopy
utility crashes
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols gobjcopy work arounds on Solaris. The first
hotspot FDS gobjcopy work around was reviewed using bug 7165060
and that fixed the dtrace test failures.
The gobjcopy utility also crashes due to empty sect
Changeset: a2b2d435f1d2
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http://hg.openjdk.java.net/jdk8/build/rev/a2b2d435f1d2
Added tag jdk8-b39 for changeset 8927dd68aee3
! .hgtags
Changeset: 56d030e5035f
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/56d030e5035f
Added tag jdk8-b39 for changeset 785af00e2827
! .hgtags
Changeset: 26423ef693ac
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26423ef693ac
Added tag jdk8-b39 for changeset 96a403721094
! .hgtags
Changeset: 56d1af561395
Author:amurillo
Date: 2012-05-11 14:54 -0700
URL:
Changeset: 9ecfdbd6aed4
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/9ecfdbd6aed4
Added tag jdk8-b39 for changeset f95fdbe525c8
! .hgtags
Changeset: 09a0ddda03cb
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/09a0ddda03cb
Added tag jdk8-b39 for changeset 7f6b44fd3034
! .hgtags
Changeset: 47cd90bf0f66
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/47cd90bf0f66
Added tag jdk8-b39 for changeset b6f529117521
! .hgtags
Changeset: 7c4eed4b6c19
Author:bae
Date: 2012-05-21 14:04 +0400
URL: http://h
Changeset: 8b869afd2eb4
Author:katleman
Date: 2012-05-17 06:20 -0700
URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8b869afd2eb4
Added tag jdk8-b39 for changeset a9f547c218d9
! .hgtags
Changeset: d10db3576c08
Author:ksrini
Date: 2012-05-04 07:55 -0700
URL:
28 matches
Mail list logo
