Dan,
I've reviewed the fixes as did not notice any problems.
Looks good.
Thanks,
Serguei
On 5/23/12 12:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
corrupts
I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols gobjcopy work arounds on Solaris. The first
hotspot FDS gobjcopy work around was
Thanks Serguei!
Dan
On 5/24/12 1:50 AM, [email protected] wrote:
Dan,
I've reviewed the fixes as did not notice any problems.
Looks good.
Thanks,
Serguei
On 5/23/12 12:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
Thanks Serguei!
Dan
On 5/24/12 1:52 AM, [email protected] wrote:
I do not see any issues with that webrev.
Looks good.
Thanks,
Serguei
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
Greetings,
This is a hotspot code review request for the second of a pair of
Full Debug Symbols go
Dan,
Code looks good.
Thank you for the work-around.
So is this HDR_FLAGS workaround also needed in all the other jdk repositories?
And I assume the windows/makefiles/defs.make change is because you determined
that the failing tests actually pre-dated the zipped debuginfo. Did you find
the ro
On 5/24/12 8:28 AM, Karen Kinnear wrote:
Dan,
Code looks good.
Thanks!
Thank you for the work-around.
So is this HDR_FLAGS workaround also needed in all the other jdk repositories?
SHF_ALLOC flag?
We know that gobjcopy crashes when running into empty ELF sections
where the SHF_ALLOC fla
Looks good. Thank you.
thanks,
Karen
On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> This is a JDK code review request for a pair of Full Debug Symbols
> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
> corrupts the SUNW_* sections on objects. This
Thanks for the review!
Dan
On 5/24/12 10:33 AM, Karen Kinnear wrote:
Looks good. Thank you.
thanks,
Karen
On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:
Greetings,
This is a JDK code review request for a pair of Full Debug Symbols
gobjcopy work arounds on Solaris. The gobjcopy ut
Not by me anyway. In fact, I think that solution is the best one!
//Fredrik
2012/5/23 Jonathan Gibbons :
> I wanted to be able to declare fields as native, but that was deemed
> unacceptable.
>
> -- Jon
>
>
> On 05/23/2012 10:05 AM, Alan Bateman wrote:
>>
>> On 23/05/2012 17:50, Kelly O'Hair wrot
The rationale for not allowing it is that it has no meaning at either
the JLS or JVMS level. It would simply be a hint for tools, and hints
for tools are best done by annotations.
-- Jon
On 05/24/2012 12:02 PM, Fredrik Öhrström wrote:
Not by me anyway. In fact, I think that solution is the b
But it has a meaning for JLS+JVMS, if you change the final static
and the native code depends on its value, and you forget to rerun
javah, then something will break. A final static field that is
used from native, is as bound to the running Java program
as any native method is. Change something with
This is a tweak to the cross-compilation rules in sun/xawt/Makefile to
force correct compilation of the sizers utility.
http://cr.openjdk.java.net/~dholmes/7171653/webrev/
webrev is against tl/jdk but I can use a different repo if you prefer.
Now that we use CFLAGS_32/64 in the cross compilati
12 matches
Mail list logo
