Re: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

2012-07-02 Thread Tim Bell
On 06/27/12 15:26, John Coomes wrote: I only looked at the hotspot changes, which are fine. One minor request. In hotspot/make/windows/makefiles/defs.make: 215 else 216 ifeq ($(USING_MINGW), true) 217 ABS_OUTPUTDIR := $(shell $(CD) $(OUTPUTDIR);$(PWD)) 218 ABS_BOOTDIR :

Re: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

2012-07-02 Thread Tim Bell
On 06/29/12 09:35, Kelly O'Hair wrote: Looks great to me. It's fantastic to see this happening. Just a few minor things: 1. For 116 DOSPATH_CMD:=$(shell cd $(JDK_TOPDIR) 2> $(DEV_NULL)&& pwd)/make/tools/mingw_build_scripts/dospath.sh since dospath.sh cannot have execute permission in th

RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-07-02 Thread Tim Bell
All- This is the hotspot-only portion of the changes to allow building on Windows with any of MKS, Cygwin, or MinGW/MSYS as the 'Unix-like' shell environment: http://cr.openjdk.java.net/~tbell/7181175/webrev.00/ A Windows-only JPRT build/test run was successful: job 2012-07-02-230003.tbell.

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-07-02 Thread David Holmes
Hi Tim, On 3/07/2012 1:52 PM, Tim Bell wrote: All- This is the hotspot-only portion of the changes to allow building on Windows with any of MKS, Cygwin, or MinGW/MSYS as the 'Unix-like' shell environment: http://cr.openjdk.java.net/~tbell/7181175/webrev.00/ A Windows-only JPRT build/test run