Hi Omair,
The fix looks good to me. I think Kumar needs to take a look at it, too,
before the fix can be pushed to a repo.
Thanks for finding and fixing this issue.
--
best regards,
Anthony
On 8/10/2012 1:48 AM, Omair Majid wrote:
On 08/09/2012 07:15 AM, Andrew Hughes wrote:
- Original
Hi Anthony,
a. although this is a build change, I have requested Omair to provide a
regression
test, IMO if we had a regression test to begin with, this would not
have been removed
during the RPATH work. We may have to check in a ".so" for linux
and solaris
variants. So my question
Hi Anthony, Omair,
Shouldn't there be a case for MacOSX as well ?
Kumar
Hi Anthony,
a. although this is a build change, I have requested Omair to provide
a regression
test, IMO if we had a regression test to begin with, this would
not have been removed
during the RPATH work. We may
- Original Message -
> On 08/09/2012 07:15 AM, Andrew Hughes wrote:
> > - Original Message -
> >> Hi Kumar,
> >>
> >> On 07/23/2012 11:19 AM, Kumar Srinivasan wrote:
> >>> My suggestion is to see if System.loadLibrary can be used, this
> >>> will
> >>> bode well for the modulariza
- Original Message -
> Hi Anthony,
>
> a. although this is a build change, I have requested Omair to provide
> a
> regression
> test, IMO if we had a regression test to begin with, this would
> not
> have been removed
> during the RPATH work. We may have to check in a ".so"
Hi Kumar, Omair,
[ adding awt-dev@ in the loop ]
On 8/10/2012 2:30 PM, Kumar Srinivasan wrote:
a. although this is a build change, I have requested Omair to provide a
regression
test, IMO if we had a regression test to begin with, this would not
have been removed
during the RPATH work.
Well, it's complicated. There's problems with JAWT on the Mac currently,
which makes it hard or even impossible to use it on that platform.
We'll add support for the Mac to a test open-sourced with 7190587 once
JAWT is working fine on the Mac in general.
--
best regards,
Anthony
On 8/10/2012
On 8/10/2012 4:24 PM, Andrew Hughes wrote:
- Original Message -
Hi Anthony,
a. although this is a build change, I have requested Omair to provide
a
regression
test, IMO if we had a regression test to begin with, this would
not
have been removed
during the RPATH work. We m
Yes, that's what should be happening as I understand it. But right now,
it's always the bootjdk. I also believe it's hardcoded to src and target
1.5.
/Erik
On 2012-08-10 14:17, Andrew Hughes wrote:
- Original Message -
It does and I believe Joel, in the langtools team, is looking at
- Original Message -
> On 8/10/2012 4:24 PM, Andrew Hughes wrote:
> > - Original Message -
> >> Hi Anthony,
> >>
> >> a. although this is a build change, I have requested Omair to
> >> provide
> >> a
> >> regression
> >> test, IMO if we had a regression test to begin with, th
On 8/10/2012 4:59 PM, Andrew Hughes wrote:
- Original Message -
On 8/10/2012 4:24 PM, Andrew Hughes wrote:
- Original Message -
Hi Anthony,
a. although this is a build change, I have requested Omair to
provide
a
regression
test, IMO if we had a regression test to begin w
- Original Message -
> It does and I believe Joel, in the langtools team, is looking at this
> issue.
>
> /Erik
>
> On 2012-08-10 03:00, Kelly O'Hair wrote:
> > I think we need to make sure that the only thing that gets built
> > with the bootjdk javac is the langtools
> > bootstrap javac
On Aug 10, 2012, at 5:17 AM, Andrew Hughes wrote:
> - Original Message -
>> It does and I believe Joel, in the langtools team, is looking at this
>> issue.
>>
>> /Erik
>>
>> On 2012-08-10 03:00, Kelly O'Hair wrote:
>>> I think we need to make sure that the only thing that gets built
>>>
Hello all-
After the fixes for 7181175 hit the hotspot-rt forest, users noticed
that hotspot/make/windows/create.bat builds were broken.
This is a supplemental fix that restores building using that .bat file.
Note that this is not on the 'product' build path at all - this is
something HotSp
On 8/10/12 3:03 PM, Tim Bell wrote:
Hello all-
After the fixes for 7181175 hit the hotspot-rt forest, users noticed
that hotspot/make/windows/create.bat builds were broken.
This is a supplemental fix that restores building using that .bat
file. Note that this is not on the 'product' build p
I wrote:
Hello all-
After the fixes for 7181175 hit the hotspot-rt forest, users noticed
that hotspot/make/windows/create.bat builds were broken.
This is a supplemental fix that restores building using that .bat
file. Note that this is not on the 'product' build path at all - this
is somet
On 08/10/2012 08:20 AM, Andrew Hughes wrote:
>>> I built jdk8/build successfully just last week. What issues are
>>> you seeing?
>>
>> Errors building hotspot, I seem to recall. But I cant reproduce it
>> anymore after pulling today. I can now confirm that the fix works for
>> me
>> with jdk8 too.
On 8/10/12 3:07 PM, Tim Bell wrote:
I wrote:
Hello all-
After the fixes for 7181175 hit the hotspot-rt forest, users noticed
that hotspot/make/windows/create.bat builds were broken.
This is a supplemental fix that restores building using that .bat
file. Note that this is not on the 'produc
Hi Anthony,
On 08/10/2012 08:29 AM, Anthony Petrov wrote:
> Actually, if Omair has a good automatic jtreg test, we would be happy to
> get it checked in with this fix. Could we see a webrev for the test please?
I have uploaded a new webrev that includes a test case too:
http://cr.openjdk.java.net
On 08/10/12 14:08, Daniel D. Daugherty wrote:
On 8/10/12 3:07 PM, Tim Bell wrote:
I wrote:
Hello all-
After the fixes for 7181175 hit the hotspot-rt forest, users noticed
that hotspot/make/windows/create.bat builds were broken.
This is a supplemental fix that restores building using that .b
20 matches
Mail list logo
