Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-21 Thread Erik Joelsson
Looks good to me. I'm ok with this. /Erik On 2012-08-20 19:14, Naoto Sato wrote: I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other

Re: [7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries

2012-08-21 Thread Andrew Hughes
- Original Message - > I can't find the original jdk8 review thread either. > > Good catch Andrew. I've created a bug ID for you : (should be live in > next 1-2 days) > 7192804 : Build should not install jvisualvm man page for OpenJDK > Thanks :-) > Needs addressing in JDK8 and 7u. JDK8

Re: [7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries

2012-08-21 Thread Seán Coffey
Looks fine to me but best to get an official jdk8 reviewer. I presume the filter-out option on macosx becomes a no-op (on OpenJDK builds) some lines later : (Images.gmk) 264 JDK_MAN_PAGES := $(filter-out jvisualvm.1, $(JDK_MAN_PAGES)) On the subject of dual Makefile maintenance, are there

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

2012-08-21 Thread Yuka Kamiya
Hi, It looks good to me. Thanks, -- Yuka (12/08/21 2:14), Naoto Sato wrote: I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other cha

Re: webrev failure?

2012-08-21 Thread Staffan Larsen
On 13 aug 2012, at 18:05, Mark Wielaard wrote: > On Sun, Aug 12, 2012 at 12:39:57PM +0100, Martijn Verburg wrote: >> Aha! :-). Any ideas on how far I need to downgrade the version of hg? >> (I'm 2.3 at the moment). > > I am at 2.2.3. The hgforest extension as maintained at > http://icedtea.cla

Re: jdk builds on the mac

2012-08-21 Thread Anthony Petrov
This patch won't work for me. I use the following "workaround" patch instead: diff -r 8a2bc6e82d81 make/java/Makefile --- a/make/java/Makefile +++ b/make/java/Makefile @@ -58,7 +58,7 @@ endif # PLATFORM ifeq ($(PLATFORM), macosx) - SUBDIRS += jobjc +# SUBDIRS += jobjc endif # PLATFORM i

Re: [7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries

2012-08-21 Thread David Holmes
On 21/08/2012 9:37 PM, Seán Coffey wrote: Looks fine to me but best to get an official jdk8 reviewer. Looks fine to me too. I presume the filter-out option on macosx becomes a no-op (on OpenJDK builds) some lines later : (Images.gmk) 264 JDK_MAN_PAGES := $(filter-out jvisualvm.1, $(JDK_MAN_P