Re: Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Phil Race
On 10/17/12 1:11 AM, Henri Gomez wrote: You need to create a bug at describing what you want to change, and then attach a new patch. Mike's review plus one other will be enough to get it into JDK 8. JDK 7u will need two reviewers, since I think the Java2D

Re: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Phil Race
PS .. I could be misremembering or misunderstanding but the other obstacle I ran into when I looked at this (ages ago) was that the freetype I built was expecting to be installed in a specific location. I didn't think it was enough to tell the JDK build to look for the freetype lib, it seemed that

Re: Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Henri Gomez
Only tried it with old build system. Le 17 oct. 2012 à 18:18, Phil Race a écrit : > On 10/17/12 1:11 AM, Henri Gomez wrote: >>> You need to create a bug at >>> describing what you want to change, and then attach a new patch. Mike's >>> review plus one o

Re: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Henri Gomez
Any sample java code available ? Le 17 oct. 2012 à 18:27, Phil Race a écrit : > PS .. I could be misremembering or misunderstanding but the other > obstacle I ran into when I looked at this (ages ago) was that the freetype > I built was expecting to be installed in a specific location. I didn't

Re: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Phil Race
I filed : (JDK-8001065) [macosx] OpenJDK on OS X should use bundled freetype, not one from the system Sample code is just import java.awt.Font; public class CreateFont { public static void main(String args[]) throws Exception { Font f = Font.createFont(Font|.TYPE1_FONT, new java.io.File("m

Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Mandy Chung
I need a reviewer to fix this build problem that only affects partial build. make/common/internal/Defs-jaxws.gmk maintains an explicit list of JAXWS packages to import from a JDK for a partial JDK. However, the list was not up-to-date and missing some JAXWS classes. You can reproduce the proble

Re: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Henri Gomez
2012/10/17 Phil Race : > I filed : (JDK-8001065) [macosx] OpenJDK on OS X should use bundled > freetype, not one from the system > > Sample code is just > > import java.awt.Font; > public class CreateFont { > > public static void main(String args[]) throws Exception { >Font f = Font.createFont(

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Kelly O'Hair
Looks ok to me. Did you plan on integrating it into jdk8/build? -kto On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote: > I need a reviewer to fix this build problem that only affects partial build. > > make/common/internal/Defs-jaxws.gmk maintains an explicit list of > JAXWS packages to import

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Mandy Chung
On 10/17/2012 11:29 AM, Kelly O'Hair wrote: Looks ok to me. Did you plan on integrating it into jdk8/build? I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl. Mandy -kto On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote: I need a reviewer to fix this build pro

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Alan Bateman
On 17/10/2012 19:33, Mandy Chung wrote: On 10/17/2012 11:29 AM, Kelly O'Hair wrote: Looks ok to me. Did you plan on integrating it into jdk8/build? I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl. It probably doesn't matter if this goes in via jdk8/tl. -Alan.

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Alan Bateman
On 17/10/2012 19:11, Mandy Chung wrote: I need a reviewer to fix this build problem that only affects partial build. make/common/internal/Defs-jaxws.gmk maintains an explicit list of JAXWS packages to import from a JDK for a partial JDK. However, the list was not up-to-date and missing some JA

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Kelly O'Hair
On Oct 17, 2012, at 11:44 AM, Alan Bateman wrote: > On 17/10/2012 19:33, Mandy Chung wrote: >> On 10/17/2012 11:29 AM, Kelly O'Hair wrote: >>> Looks ok to me. Did you plan on integrating it into jdk8/build? >> >> I can do that. Thanks for reminding me - my local repo is a clone of >> jdk8/tl.

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Mandy Chung
On 10/17/2012 11:53 AM, Kelly O'Hair wrote: On Oct 17, 2012, at 11:44 AM, Alan Bateman wrote: On 17/10/2012 19:33, Mandy Chung wrote: On 10/17/2012 11:29 AM, Kelly O'Hair wrote: Looks ok to me. Did you plan on integrating it into jdk8/build? I can do that. Thanks for reminding me - my loc

hg: jdk8/build: Added tag jdk8-b60 for changeset e07f499b9dcc

2012-10-17 Thread david . katleman
Changeset: 20ff117b5090 Author:katleman Date: 2012-10-11 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/20ff117b5090 Added tag jdk8-b60 for changeset e07f499b9dcc ! .hgtags

hg: jdk8/build/corba: 4 new changesets

2012-10-17 Thread david . katleman
Changeset: 41bb9e606efd Author:katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/41bb9e606efd Added tag jdk8-b60 for changeset 207ef43ba69e ! .hgtags Changeset: 27d87f0031bf Author:alanb Date: 2012-10-05 15:08 +0100 URL: http

hg: jdk8/build/hotspot: 31 new changesets

2012-10-17 Thread david . katleman
Changeset: 0cc77f9b31ad Author:katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0cc77f9b31ad Added tag jdk8-b60 for changeset 3cfd05b2219a ! .hgtags Changeset: 81e878c53615 Author:amurillo Date: 2012-10-05 13:37 -0700 URL:

hg: jdk8/build/jaxp: Added tag jdk8-b60 for changeset 2d1dff5310da

2012-10-17 Thread david . katleman
Changeset: 6b1db0b41d2f Author:katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/6b1db0b41d2f Added tag jdk8-b60 for changeset 2d1dff5310da ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b60 for changeset 5c5a65ad5291

2012-10-17 Thread david . katleman
Changeset: 97e5e74e2a34 Author:katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/97e5e74e2a34 Added tag jdk8-b60 for changeset 5c5a65ad5291 ! .hgtags

hg: jdk8/build/jdk: 51 new changesets

2012-10-17 Thread david . katleman
Changeset: 869519bc17ce Author:katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/869519bc17ce Added tag jdk8-b60 for changeset cec8fa02f156 ! .hgtags Changeset: 4d8b411a2bc1 Author:jgodinez Date: 2012-09-25 09:18 -0700 URL: htt

hg: jdk8/build/langtools: 22 new changesets

2012-10-17 Thread david . katleman
Changeset: 67f7408d935e Author:katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/67f7408d935e Added tag jdk8-b60 for changeset 3d2b98ffcb53 ! .hgtags Changeset: 8987971bcb45 Author:jjg Date: 2012-09-24 14:04 -0700 URL: ht