Re: Review Request: 8001753: build-infra: mismatch with full debug symbol control for hotspot

2012-12-11 Thread Erik Joelsson
On 2012-12-11 02:24, David Holmes wrote: On 11/12/2012 1:11 AM, Erik Joelsson wrote: This patch makes it possible to disable FDS in hotspot using the new build system, by translating the controlling variables in spec.gmk to what hotspot is expecting in hotspot-spec.gmk. Well I would have des

Review Request: 8001901: build-infra: Fix "misbehaving" which command on Solaris

2012-12-11 Thread Erik Joelsson
The command "which" is causing trouble on solaris. This patch removes all uses of which in configure for non windows platforms. It's still used on windows, where it has so far worked ok. http://cr.openjdk.java.net/~erikj/8001901/webrev.01/ /Erik

Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-11 Thread Erik Joelsson
This patch corrects the command line for symbol creation. http://cr.openjdk.java.net/~erikj/8004803/webrev.jdk.01/ /Erik

hg: jdk8/build/jdk: 8001753: build-infra: mismatch with full debug symbol control for hotspot

2012-12-11 Thread erik . joelsson
Changeset: 2689f6cfe835 Author:erikj Date: 2012-12-11 12:27 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2689f6cfe835 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Changing boolean values of ENABLE_DEBUG_SYMBOLS. Reviewed-by: dholmes,

hg: jdk8/build: 3 new changesets

2012-12-11 Thread erik . joelsson
Changeset: 6b96b7744913 Author:erikj Date: 2012-12-07 17:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/6b96b7744913 8004045: build-infra: Error 12 from zip when updating src.zip Summary: Hiding this error from make so that it doesn't fail Reviewed-by: ohrstrom, dholmes !

Re: Review Request: 8001901: build-infra: Fix "misbehaving" which command on Solaris

2012-12-11 Thread Kelly O'Hair
Looks ok to me. -kto On Dec 11, 2012, at 4:52 AM, Erik Joelsson wrote: > The command "which" is causing trouble on solaris. This patch removes all > uses of which in configure for non windows platforms. It's still used on > windows, where it has so far worked ok. > > http://cr.openjdk.java.ne

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-11 Thread Kelly O'Hair
I don't understand the change. What is in JAVAC_JARS that changing it's position on the command line makes any difference? -kto On Dec 11, 2012, at 5:03 AM, Erik Joelsson wrote: > This patch corrects the command line for symbol creation. > > http://cr.openjdk.java.net/~erikj/8004803/webrev.jd

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-11 Thread Tim Bell
See the message thread on build-infra with subject "Problems with non Oracle boot JDKs and class file version 52" http://mail.openjdk.java.net/pipermail/build-infra-dev/2012-December/002601.html The issue appears if the bootstrap VM uses a class file version older than what the current build

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-11 Thread Kelly O'Hair
Ok, what is confusing me is the name JAVAC_JARS. This not a list of jars, but command line options. Can we please rename this variable? -kto On Dec 11, 2012, at 10:42 AM, Tim Bell wrote: > See the message thread on build-infra with subject "Problems with non Oracle > boot JDKs and class file

OpenJDK Build Group Quarterly Report

2012-12-11 Thread Kelly O'Hair
State of the OpenJDK Build Group (last one was July 2012) (No change from the last quarterly report) The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell Phil Race David Katleman Erik Joelsson The Build Group is sponsoring the following projects: * JDK 7 U

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

2012-12-11 Thread David Holmes
Note that we went from -Xbootclasspath to just -bootclasspath. The former is a VM option and the latter a javac option. But I agree that JAVAC_JARS is a confusing name. David On 12/12/2012 4:47 AM, Kelly O'Hair wrote: Ok, what is confusing me is the name JAVAC_JARS. This not a list of jars, b

Code review: 8004904: Makefile for ntlm (was Re: com/sun/security/ntlm)

2012-12-11 Thread Weijun Wang
Hi Chris/Mark I've added a makefile, please take a look http://cr.openjdk.java.net/~weijun/8004904/webrev.00/ *build-dev* guys, I guess this won't affect the new build style. Thanks Max On 12/12/2012 09:28 AM, Weijun Wang wrote: On 12/12/2012 01:50 AM, Chris Hegarty wrote: Max, Mark