Re: Request For Review: JDK-8005090 Include com.sun.source.doctree in Tree API docs

2012-12-17 Thread Erik Joelsson
Looks good to me. /Erik On 2012-12-15 02:31, Jonathan Gibbons wrote: We need to add a recently new package into the Tree API docs, in both the old build and new build. Here are the simple diffs for the two affected files. -- Jon $ hg diff && hg diff -R jdk diff -r fb1bf5e5bc9e common/make

Re: Request For Review: JDK-8004832 Add new doclint package

2012-12-17 Thread Erik Joelsson
Looks good to me. /Erik On 2012-12-15 02:46, Jonathan Gibbons wrote: We need to add a new package, com.sun.tools.doclint, for the upcoming new doclint feature described in JEP 105. Please review the minor build-related changes for the old and new build system in the following webrevs http:

RFR: 8004823: Add VM support for type annotation reflection

2012-12-17 Thread Joel Borggrén-Franck
Hi, Here is a webrev for adding VM support for type annotation reflection: http://cr.openjdk.java.net/~jfranck/8004823/webrev.v4/ Type annotations are coming with JDK 8, the proposed language changes can be found from here: http://openjdk.java.net/projects/type-annotations/ Since runtime visib

Re: Request For Review: JDK-8005090 Include com.sun.source.doctree in Tree API docs

2012-12-17 Thread Kelly O'Hair
Looks fine to me too. -kto On Dec 14, 2012, at 5:31 PM, Jonathan Gibbons wrote: > We need to add a recently new package into the Tree API docs, in both the old > build and new build. Here are the simple diffs for the two affected files. > > -- Jon > > > $ hg diff && hg diff -R jdk > diff -r

Re: Request For Review: JDK-8004832 Add new doclint package

2012-12-17 Thread Kelly O'Hair
Look ok to me. -kto On Dec 14, 2012, at 5:46 PM, Jonathan Gibbons wrote: > We need to add a new package, com.sun.tools.doclint, for the upcoming new > doclint feature described in JEP 105. > > Please review the minor build-related changes for the old and new build > system in the following we

Re: RFR: 8004823: Add VM support for type annotation reflection

2012-12-17 Thread David Holmes
Hi Joel, This all looks fine to me. I have no comments. Didn't even see any nits to pick. :) Thanks, David On 18/12/2012 2:47 AM, Joel Borggrén-Franck wrote: Hi, Here is a webrev for adding VM support for type annotation reflection: http://cr.openjdk.java.net/~jfranck/8004823/webrev.v4/ T

Fwd: Re: RFR (JDK-7190137) Add support for JVM_VARIANT minimal1

2012-12-17 Thread David Holmes
This has been pushed to build-infra (thanks Erik) so I would now like it to get pushed to jdk8/build and up to jdk8/jdk8. Thanks, David Original Message Subject: Re: RFR (JDK-7190137) Add support for JVM_VARIANT minimal1 Date: Mon, 17 Dec 2012 09:57:21 +0100 From: Erik Joelsso