New webrev. I decided that David was right, it really should be in
closed so I moved it there, along with the closed version numbers file
and the reading of it. These files are also changing names slightly to
avoid the .numbers extension which is just weird.
http://cr.openjdk.java.net/~erikj/8
Looks ok.
---
Is it just me, or is this m4 stuff hard to review with plain diffs. :^(
One of these days someone will come up with a difference tool that takes into
account the type
of file it is and stop treating all files as simple text files.
Has anyone ever tried http://www.guiffy.com/?
-k
Not sure of how all the bits click together between open and closed but
on the surface this looks okay.
One nit. The old version number file had a copyright
Copyright (c) 2012,
yet somehow the new one became
Copyright (c) 2011, 2012,
??
Really I think it should now be:
Copyright (c) 2012,
Fixed the copyright header of that file.
http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/
/Erik
On 2013-01-01 23:58, David Holmes wrote:
Not sure of how all the bits click together between open and closed
but on the surface this looks okay.
One nit. The old version number file had a
Sorry Erik I misunderstood the change that had been made. I thought
common/autoconf/version-numbers was replacing
common/autoconf/closed.version.numbers but it wasn't - that was the
original copyright I was looking at.
That means the correct copyright here would now be:
Copyright (c) 2011, 20
