I should have checked myself, but it was late. Here is a new webrev with
all copyright years updated.
http://cr.openjdk.java.net/~erikj/8005347/webrev.root.04/
/Erik
On 2013-01-02 01:56, David Holmes wrote:
Sorry Erik I misunderstood the change that had been made. I thought
common/autoconf/ve
In build-infra, an attempt at unifying the handling of properties files
was introduced and used in jaxp jaxws. It changed how properties were
cleaned quite drastically for these repos, trying to mimic what was
going on with StripProperties in jdk and langtools, but using sed. This
worked pretty
Changeset: 2d9bb72b4e34
Author:erikj
Date: 2012-12-30 12:15 +0100
URL: http://hg.openjdk.java.net/jdk8/build/rev/2d9bb72b4e34
8004490: build-infra: mac: hotspot is always built in product, regardless of
--with-debug-level setting
Reviewed-by: tbell
! common/autoconf/generated-conf
I accidentally hit hg push in the wrong shell window and pushed this
prematurely. What should I do now?
/Erik
On 2013-01-02 10:50, Erik Joelsson wrote:
I should have checked myself, but it was late. Here is a new webrev
with all copyright years updated.
http://cr.openjdk.java.net/~erikj/8005
As it was pushed to build-infra I don't see any major problem. If there
are changes needed due to review comments then push a follow up changeset.
David
On 2/01/2013 8:58 PM, Erik Joelsson wrote:
I accidentally hit hg push in the wrong shell window and pushed this
prematurely. What should I do
This is the open part of this review. The changes are mostly concerning
compare logic and introducing a couple of new variables in spec for
images directories.
Contributed by Tim Bell and myself.
http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/
http://cr.openjdk.java.net/~erikj/800563
Missed the changes to common/makefiles/Jprt.gmk. New webrev:
http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/
/Erik
On 2013-01-02 17:14, Erik Joelsson wrote:
This is the open part of this review. The changes are mostly
concerning compare logic and introducing a couple of new variables
Looks ok to me.
-kto
On Jan 2, 2013, at 2:46 AM, Erik Joelsson wrote:
> In build-infra, an attempt at unifying the handling of properties files was
> introduced and used in jaxp jaxws. It changed how properties were cleaned
> quite drastically for these repos, trying to mimic what was going on
Full steam ahead...if you ask me...
-kto
On Jan 2, 2013, at 2:58 AM, Erik Joelsson wrote:
> I accidentally hit hg push in the wrong shell window and pushed this
> prematurely. What should I do now?
>
> /Erik
>
> On 2013-01-02 10:50, Erik Joelsson wrote:
>> I should have checked myself, bu
Looks ok with me.
-kto
On Jan 2, 2013, at 10:34 AM, Erik Joelsson wrote:
> Missed the changes to common/makefiles/Jprt.gmk. New webrev:
>
> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/
>
> /Erik
>
> On 2013-01-02 17:14, Erik Joelsson wrote:
>> This is the open part of this review
10 matches
Mail list logo
