Re: Request for review and approval to fix 8012366 in 7update

2013-07-12 Thread David Holmes
On 12/07/2013 4:57 PM, Erik Joelsson wrote: Looks good to me though I'm not a jdk7 reviewer. I am :) Tim I think this is okay. Certainly it only makes sense to build install bundles if building install. I just wonder why building install bundles has to appear at this top-level anyway. But

fail to build profiles in my system

2013-07-12 Thread Jin Mingjian
Hi, build team, very thanks for the great new build system. I always succeed to build whole by "make all". But fail to build profiles by "make profiles". This command used to work in the initial weeks after the profile works into the hg repo. I am using an arch based custom linux. So, I do not e

Re: fail to build profiles in my system

2013-07-12 Thread David Holmes
Hi Jin, Try "make images profiles" as a workaround. I suspect there is a missing dependency. David On 12/07/2013 6:14 PM, Jin Mingjian wrote: Hi, build team, very thanks for the great new build system. I always succeed to build whole by "make all". But fail to build profiles by "make profile

Re: Request for review and approval to fix 8012366 in 7update

2013-07-12 Thread Dalibor Topic
On 7/12/13 8:57 AM, Erik Joelsson wrote: > Looks good to me though I'm not a jdk7 reviewer. Looks good to me, too. Local OpenJDK build on OS X and an OpenJDK linux build on JPRT both passed. Please send in a fresh phase 2 approval request to the jdk7u-dev list. cheers, dalibor topic > /Erik >

Re: Request for review and approval to fix 8012366 in 7update

2013-07-12 Thread Tim Bell
Dalibor: Looks good to me, too. Local OpenJDK build on OS X and an OpenJDK linux build on JPRT both passed. Thanks very much for the review and the extra testing. As an added data point to help justify this fix, we just got email from our third internal user who ran into this bug last nigh

Re: Request for review and approval to fix 8012366 in 7update

2013-07-12 Thread Tim Bell
On 07/12/13 12:02 AM, David Holmes wrote: I am :) Tim I think this is okay. Certainly it only makes sense to build install bundles if building install. Good. Thanks for the review. I just wonder why building install bundles has to appear at this top-level anyway. But that's a different iss

Re: fail to build profiles in my system

2013-07-12 Thread Jin Mingjian
David, very thanks for your reply. "make images profiles" still yeilded the same "No rule to make target" error. I also suspect some tool(s) has meet some problem when extracting the classes. I will continue to care this problem in my spare:) I will let you know when it's gone or the reason found.