Re: How to add options to the javac build in the JDK 8 repo?

2013-08-14 Thread Erik Joelsson
Hello Joe, On 2013-08-13 23:31, Joe Darcy wrote: A follow-up, the build incantation to embed a comma seems to be "(COMMA)". Therefore, I will upgrade this to a code review request: Actually, you need to use $(COMMA) for it to work. Unfortunately FLAGS isn't a valid parameter to the SetupJavaC

Re: How to add options to the javac build in the JDK 8 repo?

2013-08-14 Thread Joe Darcy
Hi Erik, On 08/14/2013 03:08 AM, Erik Joelsson wrote: Hello Joe, On 2013-08-13 23:31, Joe Darcy wrote: A follow-up, the build incantation to embed a comma seems to be "(COMMA)". Therefore, I will upgrade this to a code review request: Actually, you need to use $(COMMA) for it to work. Unfort

RFR: JDK-8023075: JDK-5049299 has broken old make in jdk8

2013-08-14 Thread Brad Wetmore
Rob, I'm not sure what happened, but I'm guessing your editor made a couple of glaring mistakes. 1. in the clean clobber target command section instead of 2. No newline at end of file In: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4b0be7341ef % hg diff . diff --git a/make/ja

Re: RFR: JDK-8023075: JDK-5049299 has broken old make in jdk8

2013-08-14 Thread David Katleman
On 8/14/2013 7:07 PM, Brad Wetmore wrote: Rob, I'm not sure what happened, but I'm guessing your editor made a couple of glaring mistakes. 1. in the clean clobber target command section instead of 2. No newline at end of file In: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4

Re: RFR: JDK-8023075: JDK-5049299 has broken old make in jdk8

2013-08-14 Thread Brad Wetmore
Thanks, David. Pushed. You should be able to build the JCE jar files. Brad P.S. Yes, Alan, I am making progress on the JCE build issue. ;) On 8/14/2013 7:11 PM, David Katleman wrote: On 8/14/2013 7:07 PM, Brad Wetmore wrote: Rob, I'm not sure what happened, but I'm guessing your edito

Re: Create a jvm.cfg for zero on 32 bit architectures

2013-08-14 Thread David Holmes
On 14/08/2013 1:53 AM, Omair Majid wrote: On 08/12/2013 12:51 AM, David Holmes wrote: Hi Omair, On 10/08/2013 1:25 AM, Omair Majid wrote: Hi, OpenJDK fails to build with zero currently on 32 bit architectures. There's a non-architecture-specific compilation error that I fixed [1]. That makes