Build part of the changes are fine.
/Erik
On 2013-09-21 16:26, Joel Borggren-Franck wrote:
Hi
A while ago [1] I introduced an extra field in to j.l.r.Method,
j.l.r.Constructor, and j.l.r.Field in order to support reflection for
type annotations. These fields were intended to be removed later,
Or wait, you added a c-file to libjava and want the old build to keep
working, then you need to add that file to jdk/make/java/java/FILES_c.gmk.
/Erik
On 2013-09-23 09:59, Erik Joelsson wrote:
Build part of the changes are fine.
/Erik
On 2013-09-21 16:26, Joel Borggren-Franck wrote:
Hi
A w
Hi,
On 2013-09-22, Robert Lougher wrote:
> Hi,
>
> Not a reviewer, but in Field.c the parameter to
> getTypeAnnotationBytes0 is a field not a method.
>
Thanks, will rename that parameter before pushing.
cheers
/Joel
I have looked (primarily) at the jdk and root repo changes, which look
good to me.
You say that the changes in jdk are just to support importing .diz
files, but it looks like you are enabling FDS in the jdk build too, or
am I missing something?
/Erik
On 2013-09-21 05:36, Daniel D. Daugherty
Erik,
Thanks for the review!
On 9/23/13 2:36 AM, Erik Joelsson wrote:
I have looked (primarily) at the jdk and root repo changes, which look
good to me.
Thanks.
You say that the changes in jdk are just to support importing .diz
files, but it looks like you are enabling FDS in the jdk buil
Hi all,
Updated webrev: http://cr.openjdk.java.net/~jfranck/8009719/webrev.02/
Adds Field.c to make/java/java/FILES_c.gmk (old build)
Renames parameter in Field.c from method to field
Thanks for the suggestions/fixes!
cheers
/Joel
On 2013-09-21, Joel Borggren-Franck wrote:
> Hi
>
> A while ag
Hi,
Not a reviewer, but in Field.c the parameter to
getTypeAnnotationBytes0 is a field not a method.
Rob.
On 21 September 2013 15:26, Joel Borggren-Franck wrote:
> Hi
>
> A while ago [1] I introduced an extra field in to j.l.r.Method,
> j.l.r.Constructor, and j.l.r.Field in order to support ref
Sean
The point is that OpenJDK7u is not open source while OpenJDK7 is... Following is
a snippet of the make log joined...
That's the same story for the HSX project. Thus either the OpenJDK7u is an open
source project and then the makefiles are wrong, either it is not and then I
need the backpo
I'm happy with the build part now.
/Erik
On 2013-09-23 16:00, Joel Borggren-Franck wrote:
Hi all,
Updated webrev: http://cr.openjdk.java.net/~jfranck/8009719/webrev.02/
Adds Field.c to make/java/java/FILES_c.gmk (old build)
Renames parameter in Field.c from method to field
Thanks for the sug
It's certainly not supposed to fail like that. I'm not able to reproduce
this problem cloning from http://hg.openjdk.java.net/jdk7u/jdk7u-dev.
From where did you get your sources?
/Erik
On 2013-09-23 17:51, Francis ANDRE wrote:
Sean
The point is that OpenJDK7u is not open source while OpenJD
I don't see the failure either. Ran an OpenJDK test job through JPRT. I
wonder if make version and/or shell env could have an impact ? Can you
share more details Francis ?
I see an OPENJDK condition expression in trace.make and wonder if that's
being parsed incorrectly for this issue ?
http
I thought I would pitch in my build times:
On i7 MBP with SSD, when booted natively into Windows 7 64bits - 9 min
32 sec
Same but virtualized with 4 cores and 4 Gb ram: 15 min 10 sec
Ivan
On 8/29/13 9:36 AM, Weijun Wang wrote:
I have watched this thread for some time. Yes, SSD should be faste
Please review the following updated fix which has removed the CAST_*_OOP
macro
implementation in favor of two inlined template methods, cast_to_oop() &
cast_from_oop().
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.1/
Bug: JDK8 b44 hotspot:src/share/vm/oops/klass.hpp: E
Thank you Magnus for reviewing the build piece.
Lois
On 9/20/2013 2:59 AM, Magnus Ihse Bursie wrote:
On 2013-09-19 16:37, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The build changes part of the fix looks unproble
I just did a fresh clone of hotspot from jdk7u-dev. The command line build
finished ok.
The project files got created also just fine but build from Visual studio
failed:
1>C:\Program Files
(x86)\MSBuild\Microsoft.Cpp\v4.0\Platforms\x64\Microsoft.Cpp.x64.Targets(63,5):
error : Required file ""
Le 23/09/2013 18:54, Erik Joelsson a écrit :
It's certainly not supposed to fail like that. I'm not able to reproduce this
problem cloning from http://hg.openjdk.java.net/jdk7u/jdk7u-dev. From where
did you get your sources?
From http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot with hg clone
htt
Erik
I got the same error with this repository: hg clone
http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot
$ pwd
/cygdrive/z/DEV/OpenJDK7u
hg clone http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot
cd hotspot/make
make all_debug
...
Generating jvmtifiles/jvmtiEnter.cpp
Generating jvmtifiles/
Sean
From my perspective, it seems that the OPENJDK variable is not set. I don't
know about JPRT and googled for it but did found anything relevant; Where is
located JPRT?
Francis
$ make help
Makefile for the Hotspot workspace.
Default behavior is to build and create an export area for the j
Sean
I found a bypass for run a full build. here the explanation
the Z:\DEV\OpenJDK7u\hotspot\build\windows\windows_i486_compiler1\local.make
contains
# Generated file
Variant=compiler1
WorkSpace=Z:\DEV\OpenJDK7u\hotspot
BootStrapDir=C:\Progra~1\Java\jdk1.6.0_35
BuildUser=FrancisANDRE
HS_VER=2
Sean
OK, I found the problem: I had in the Windows environement variables a variable
named OpenJDK, which under nmake/make gets translated into OPENJDK under cygwin,
but echo $OpenJDK prints the value while echo $OPENJDK prints nothing!
Sorry for the noise and thanks for your attention on my
Francis,
Is it possible for you to change the locale into English?
There are a few sed commands in the make script that may not work nicely with
non-ascii symbols
I just did the same make on the same clone and it succeeded.
Ivan
On Sep 24, 2013, at 6:46 AM, Francis ANDRE
wrote:
> Erik
>
>
Ah, you've figured it out.
Thanks for the resolution summary.
Ivan
On Sep 24, 2013, at 10:41 AM, Ivan Krylov
wrote:
> Francis,
>
> Is it possible for you to change the locale into English?
> There are a few sed commands in the make script that may not work nicely with
> non-ascii symbols
>
22 matches
Mail list logo
