RFR: JDK-8006661 Use LC_ALL=C instead of LANG=C in compare.sh

2013-09-25 Thread Magnus Ihse Bursie
We need to use LC_ALL=C instead of LANG=C because the latter does not change LC_MESSAGES, which is necessary if we are grepping for english words in the output from diff. Webrev: http://cr.openjdk.java.net/~ihse/JDK-8006661-use-LC_ALL-in-compare.sh/webrev.01 /Magnus

Re: RFR: JDK-8006661 Use LC_ALL=C instead of LANG=C in compare.sh

2013-09-25 Thread Tim Bell
Magnus: We need to use LC_ALL=C instead of LANG=C because the latter does not change LC_MESSAGES, which is necessary if we are grepping for english words in the output from diff. Webrev: http://cr.openjdk.java.net/~ihse/JDK-8006661-use-LC_ALL-in-compare.sh/webrev.01 Looks good to me. /

Re: FR (L) JDK-7195622 (round 2): CheckUnhandledOops has limited usefulness now

2013-09-25 Thread Christian Thalinger
This looks good. Thank you for changing it to template methods instead of using macros. On Sep 23, 2013, at 2:17 PM, Lois Foltan wrote: > > Please review the following updated fix which has removed the CAST_*_OOP macro > implementation in favor of two inlined template methods, cast_to_oop() &

hg: jdk8/build: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week

2013-09-25 Thread tim . bell
Changeset: 91f47e8da5c6 Author:tbell Date: 2013-09-25 12:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/91f47e8da5c6 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties

hg: jdk8/build/corba: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week

2013-09-25 Thread tim . bell
Changeset: 428428cf5e06 Author:tbell Date: 2013-09-25 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/428428cf5e06 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties

hg: jdk8/build/jaxp: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week

2013-09-25 Thread tim . bell
Changeset: 02bfab2aa938 Author:tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/02bfab2aa938 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties

hg: jdk8/build/jaxws: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week

2013-09-25 Thread tim . bell
Changeset: df5d4d016425 Author:tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/df5d4d016425 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties

hg: jdk8/build/jdk: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week

2013-09-25 Thread tim . bell
Changeset: 946f3fd5f8bf Author:tbell Date: 2013-09-25 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/946f3fd5f8bf 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties ! makefiles/jprt.propert

hg: jdk8/build/hotspot: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week

2013-09-25 Thread tim . bell
Changeset: c81dd5393a5e Author:tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c81dd5393a5e 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties

hg: jdk8/build/langtools: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week

2013-09-25 Thread tim . bell
Changeset: 985abf1cd327 Author:tbell Date: 2013-09-25 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/985abf1cd327 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties

Re: FR (L) JDK-7195622 (round 2): CheckUnhandledOops has limited usefulness now

2013-09-25 Thread Lois Foltan
On 9/25/2013 3:06 PM, Christian Thalinger wrote: This looks good. Thank you for changing it to template methods instead of using macros. Great, thank you for taking the time to look at this given your week at JavaOne. Lois On Sep 23, 2013, at 2:17 PM, Lois Foltan wrote: Please review t