On 30/09/2013 8:41 PM, Magnus Ihse Bursie wrote:
On 2013-09-25 08:31, Jungwoo Ha wrote:
So now I can run make, and the next problem is on adlc.
Compiling
/home/jwha/clients/jdk8_build/hotspot/src/share/vm/adlc/adlparse.cpp
rm -f ../generated/adfiles/adlparse.o
/path/../to/compiler/bin/g++ -DLINU
On 2013-10-02 01:22, Joe Darcy wrote:
The webrev above and patch below adds the "auxiliaryclass", "empty",
and "try" categories:
--- old/makefiles/Setup.gmk2013-10-01 15:53:23.0 -0700
+++ new/makefiles/Setup.gmk2013-10-01 15:53:23.0 -0700
@@ -27,7 +27,7 @@
# To build w
On 2013-10-01 23:41, Bhavesh Patel wrote:
Hi,
There is a bug in jdk/make/docs/Makefile for JDK8. The bug is listed at
https://bugs.openjdk.java.net/browse/JDK-8025741. The Makefile for JDK 8 does not
include the DEV_DOCS_URL that should point to the developer documentation URL for JDK
8. T
The change looks ok. Pushing it through JPRT sounds like a good idea.
/Erik
On 2013-10-02 01:22, Joe Darcy wrote:
Hello,
As a follow-up to JDK-8024643 "Turn on javac lint checking in
building the jdk repo", the time approaches to enable a few more lint
warnings in the build of the jdk repo:
Thanks Magnus.
I have made the changes to the common/makefiles/javadoc/Javadoc.gmk file for
the new build. I have uploaded the updated webrev at
http://cr.openjdk.java.net/~bpatel/8025741/webrev.01/
Thanks,
Bhavesh.
- Original Message -
From: magnus.ihse.bur...@oracle.com
To: bhavesh.x
On 2013-10-02 10:32, Bhavesh Patel wrote:
Thanks Magnus.
I have made the changes to the common/makefiles/javadoc/Javadoc.gmk file for
the new build. I have uploaded the updated webrev at
http://cr.openjdk.java.net/~bpatel/8025741/webrev.01/
Looks good to me (but you'll need a formal reviewer
Looks good to me Joe. Good to see more lint options being enabled.
-Chris.
On 02/10/2013 00:22, Joe Darcy wrote:
Hello,
As a follow-up to JDK-8024643 "Turn on javac lint checking in building
the jdk repo", the time approaches to enable a few more lint warnings in
the build of the jdk repo:
JD
Hi Lois,
Looks good, might be worth clarifying that this disables CheckUnhandledOops for
both 32 and 64-bit Windows.
Thanks,
Christian
From: hotspot-runtime-dev-boun...@openjdk.java.net
[mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Lois Foltan
Sent: Tuesday, Oct
On 10/2/2013 8:23 AM, Christian Tornqvist wrote:
Hi Lois,
Looks good, might be worth clarifying that this disables
CheckUnhandledOops for both 32 and 64-bit Windows.
Hi Christian,
Thank you for the review. I will update the the bug with this
information and include it in the summary for
Bhavesh:
Looks good to me as well.
/Tim
On 10/ 2/13 01:38 AM, Magnus Ihse Bursie wrote:
On 2013-10-02 10:32, Bhavesh Patel wrote:
Thanks Magnus.
I have made the changes to the common/makefiles/javadoc/Javadoc.gmk
file for the new build. I have uploaded the updated webrev at
http://cr.open
Dan
You have my thumbs up changes look good
> -Original Message-
> From: David Holmes
> Sent: Tuesday, October 01, 2013 8:53 PM
> To: Daniel Daugherty
> Cc: serviceability-...@openjdk.java.net; build-dev;
> hotspot-runtime-...@openjdk.java.net
> Subject: Re: code review round 0 for Ful
This patch adds java.time to src.zip by replacing all the java/*
includes with just java. It also removes two packages that no longer
exist. I have verified that the resulting src.zip only differs by adding
sources in java/time.
http://cr.openjdk.java.net/~erikj/8024522/webrev.jdk.01/
/Erik
Changeset: dd43ccb3bac9
Author:ihse
Date: 2013-10-01 11:08 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dd43ccb3bac9
8019219: Fix typo in jdk/makefiles "default" targets
Reviewed-by: erikj
! makefiles/CompileLaunchers.gmk
! makefiles/CompileNativeLibraries.gmk
Changese
Erik:
This patch adds java.time to src.zip by replacing all the java/*
includes with just java. It also removes two packages that no longer
exist. I have verified that the resulting src.zip only differs by
adding sources in java/time.
http://cr.openjdk.java.net/~erikj/8024522/webrev.jdk.01
Changeset: 0f704e36bc5d
Author:ihse
Date: 2013-10-01 10:58 +0200
URL: http://hg.openjdk.java.net/jdk8/build/rev/0f704e36bc5d
8006661: Use LC_ALL=C instead of LANG=C compare.sh
Reviewed-by: tbell
! common/bin/compare.sh
Changeset: 4faa09c7fe55
Author:erikj
Date: 2013-10-02
David,
Thanks for the thorough review (as always)!
It will take me a while to process all the comments, but another
reply will be forthcoming.
Dan
On 10/1/13 8:52 PM, David Holmes wrote:
Hi Dan,
Overall thumbs up. A couple of minor issues that need fixing. A few
meta-comments (I hate seein
Ron,
Thanks for the review.
Dan
On 10/2/13 8:44 AM, Ron Durbin wrote:
Dan
You have my thumbs up changes look good
-Original Message-
On 21/09/2013 1:36 PM, Daniel D. Daugherty wrote:
Greetings,
I have the initial support for Full Debug Symbols (FDS) on MacOS X done
and ready fo
Hi Jeremy,
On 3/10/2013 10:20 AM, Jeremy Manson wrote:
I note that the bottom of spec.gmk.in has this nugget:
# Include the custom-spec.gmk file if it exists
-include $(dir @SPEC@)/custom-spec.gmk
There is no support in the configuration file to make sure that this file
exists in the build dir
Nashorn project ($jdk8/nashorn) uses "make" directory contents. Contains
NetBeans project. There is a old-style "Makefile" there which can be
removed. (Nashorn does not even build with old-style build. That
Makefile just instructs to run 'new style build' for nashorn).
-Sundar
Magnus Ihse Bur
Hi Jeremy,
On 3/10/2013 12:58 PM, Jeremy Manson wrote:
Hi David,
I only sort-of understand what you are saying. My workflow is to create
a build/ directory, run configure from the JDK directory in that build/
directory, and then run make. I also want some custom options in my spec.
With the
20 matches
Mail list logo
