Re: JDK7u40: webrev does not seem to work properly on WXP/Cygwin

2013-10-07 Thread Magnus Ihse Bursie
On 2013-10-04 21:58, Francis ANDRE wrote: Hi I am trying to build a webrev for an outgoing patch on a WXP/x86/Cygwin platform, but it seems that the webrev script is not handling properly the /cygdrive/ path. So, I am wondering if there a specific configuration guide for using this script und

Re: RFR (S): JDK-8025933 Configure should support French cl.exe

2013-10-07 Thread Magnus Ihse Bursie
On 2013-10-06 05:19, David Holmes wrote: Magnus, Echoing Naoto's comments I don't agree that we should be supporting this. In the original email a workaround was mentioned using an environment variable - if that is the case then I don't think we need to do anything here. Even if not, who know

Re: JDK7u40: webrev does not seem to work properly on WXP/Cygwin

2013-10-07 Thread Vadim Pakhnushev
I installed pdksh from obsolete cygwin packages and it's working fine, like "pdksh /usr/bin/webrev.ksh ...", ksh (which is mksh I believe) is not working for me. Thanks, Vadim On 07.10.2013 11:32, Magnus Ihse Bursie wrote: On 2013-10-04 21:58, Francis ANDRE wrote: Hi I am trying to build a

RFR: JDK-8005924: Make it possible to set both --with-user-release-suffix and --with-build-number

2013-10-07 Thread Erik Joelsson
This patch changes the behavior of --with-build-number and --with-user-release-suffix. Previously, you could only set one or the other and setting build-number would override user-release-suffix. With this patch it's possible to set both. This simplifies nightly builds of various group forests

Re: RFR: JDK-8005924: Make it possible to set both --with-user-release-suffix and --with-build-number

2013-10-07 Thread Magnus Ihse Bursie
On 2013-10-07 14:21, Erik Joelsson wrote: This patch changes the behavior of --with-build-number and --with-user-release-suffix. Previously, you could only set one or the other and setting build-number would override user-release-suffix. With this patch it's possible to set both. This simplifie

Re: RFR: JDK-8005924: Make it possible to set both --with-user-release-suffix and --with-build-number

2013-10-07 Thread Tim Bell
Erik: On 10/ 7/13 05:44 AM, Magnus Ihse Bursie wrote: On 2013-10-07 14:21, Erik Joelsson wrote: This patch changes the behavior of --with-build-number and --with-user-release-suffix. Previously, you could only set one or the other and setting build-number would override user-release-suffix. W

Re: RFR (S): JDK-8025921 Make LOG=debug output more readable

2013-10-07 Thread Erik Joelsson
Unfortunately, the patch failed when I tried submitting it. Usage of the ListPathsSafely macro in SetupArchive is a bit different and needs to be adjusted. Here is a webrev that I have verified to work: http://cr.openjdk.java.net/~erikj/8025921/webrev.root.01/ I also reduced duplication and sl

Re: RFR (S): JDK-8025933 Configure should support French cl.exe

2013-10-07 Thread Francis ANDRE
Le 07/10/2013 11:32, Magnus Ihse Bursie a écrit : On 2013-10-06 05:19, David Holmes wrote: Magnus, Echoing Naoto's comments I don't agree that we should be supporting this. In the original email a workaround was mentioned using an environment variable - if that is the case then I don't think

Re: RFR (S): JDK-8025933 Configure should support French cl.exe

2013-10-07 Thread Naoto Sato
Hi Magnus, I think we need to make it clear that the locale we support for building the JDK is US English, which is proven to work, and it should be documented in README-builds.html or similar. Your change in configure script looks good, in order for passing non-English CL.EXE through, but I

hg: jdk8/build: 8005924: Make it possible to set both --with-user-release-suffix and --with-build-number

2013-10-07 Thread erik . joelsson
Changeset: 9b102ab97693 Author:erikj Date: 2013-10-07 18:19 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/9b102ab97693 8005924: Make it possible to set both --with-user-release-suffix and --with-build-number Reviewed-by: ihse, tbell ! common/autoconf/generated-configure.sh

Re: RFR JDK-8025920 webrev.ksh does not provide any details about changes in zip files

2013-10-07 Thread Mike Duigou
Looks good to me. Thanks for this contribution! Mike On Oct 4 2013, at 07:49 , Tomas Hurka wrote: > Hi Kumar, > updated webrev: > > On 4 Oct 2013, at 16:08, Kumar Srinivasan wrote: > >> Hi Tomas, >> >> Looks good!, and thanks for doing th

Re: RFR (S): JDK-8025933 Configure should support French cl.exe

2013-10-07 Thread David Holmes
On 8/10/2013 2:28 AM, Francis ANDRE wrote: Le 07/10/2013 11:32, Magnus Ihse Bursie a écrit : On 2013-10-06 05:19, David Holmes wrote: Magnus, Echoing Naoto's comments I don't agree that we should be supporting this. In the original email a workaround was mentioned using an environment variabl