Re: Building OpenJDK 8 on Windows 8.1 Pro -- problems with msvcr100.dll

2013-11-05 Thread Magnus Ihse Bursie
On 2013-11-04 19:16, Rich P wrote: Hello -- Are there any known issues with msvcr100.dll when building OpenJDK8 on Windows 8.1 Pro? The msvcr100.dll is typically a source of problems when building OpenJDK on Windows. :-) We need to get hold of a version of msvcr100.dll which matches the pl

Re: Building OpenJDK 8 on Windows 8.1 Pro -- problems with msvcr100.dll

2013-11-05 Thread Magnus Ihse Bursie
On 2013-11-05 09:01, Magnus Ihse Bursie wrote: Using the setup below, the configure script fails with the following msvcr100.dll-related errors: (1) configure: The file type of the located msvcr100.dll is PE32+ executable for MS Windows (DLL) (GUI) Mono/.Net assembly That's a new one. Where

Re: RFR: JDK-8027698: Platform specific jars are not being signed by the sign-jars target

2013-11-05 Thread Erik Joelsson
On 2013-11-04 20:57, Bradford Wetmore wrote: Hi Erik, Thanks for the update! Looks good, but one minor comment: SignJars.gmk 78:100:106:111-116 > 80 chars per line. Thanks. We have not enforced 80 chars in any other file in the new build system. Has this been a habit before? I

Re: Build failure with gnu make 4.0 on Arch Linux

2013-11-05 Thread Erik Joelsson
So this only happens in hotspot because of make/linux/makefiles/adjust-mflags.sh. I would suggest this change to fix it. It adds -I to a set of options that cannot be combined with -j sharing the same dash (since -I requires an argument). diff -r ddc3758f68db make/linux/makefiles/adjust-mflags

Re: Removal of the old build system, partial and preliminary review (part 3)

2013-11-05 Thread Magnus Ihse Bursie
On 2013-11-04 18:47, Phil Race wrote: I had this problem recently and I don't think you need restore the files - just the directory. I used hg mv to relocate the files but because *all* files were moved out of the directory so hg deleted the directory. It was sufficient to mkdir again for webr

RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed

2013-11-05 Thread Magnus Ihse Bursie
Bug: https://bugs.openjdk.java.net/browse/JDK-8027836 If the last file from a directory is moved by hg mv, the directory itself is removed by mercurial. Webrev cannot handle this situation properly. WebRev: http://cr.openjdk.java.net/~ihse/JDK-8027836-fix-webrev-moved-from-removed-dir/webrev

Re: Removal of the old build system, partial and preliminary review (part 3)

2013-11-05 Thread Magnus Ihse Bursie
On 2013-11-04 12:44, Magnus Ihse Bursie wrote: Unfortunately, WebRev is not very intelligent at presenting these changes. :-( I have made modifications to files that I have also moved, but WebRev just lists these files as "New" without any reference or diff with the original file. I don't kno

Re: Build failure with gnu make 4.0 on Arch Linux

2013-11-05 Thread Henry Jen
+1, that would work. I just wondering if it’s better to have I in both bracket to be tolerant to case like -RsI, although it’s not a problem now, but that seems legal options to me. Cheers, Henry On Nov 5, 2013, at 4:27 AM, Erik Joelsson wrote: > So this only happens in hotspot because of >

RE: Building OpenJDK 8 on Windows 8.1 Pro -- problems with msvcr100.dll

2013-11-05 Thread Rich P
Magnus -- Thanks for your help! My comments below... > Date: Tue, 5 Nov 2013 10:31:18 +0100 > From: magnus.ihse.bur...@oracle.com > To: tempbo...@hotmail.com > CC: build-dev@openjdk.java.net > Subject: Re: Building OpenJDK 8 on Windows 8.1 Pro -- problems with > msvcr100.dll > > On 2013-11-0

Re: Build failure with gnu make 4.0 on Arch Linux

2013-11-05 Thread Erik Joelsson
You are right, that would be more correct. /Erik On 2013-11-05 17:13, Henry Jen wrote: +1, that would work. I just wondering if it’s better to have I in both bracket to be tolerant to case like -RsI, although it’s not a problem now, but that seems legal options to me. Cheers, Henry On Nov 5

Re: Building OpenJDK 8 on Windows 8.1 Pro -- problems with msvcr100.dll

2013-11-05 Thread Erik Joelsson
When modifying a .m4 file, you need to have autoconf (version 2.69) installed to regenerate generated-configure.sh. When running configure, we have a check that makes sure it has been properly regenerated. /Erik On 2013-11-05 17:37, Rich P wrote: Magnus -- Thanks for your help! My comment

Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed

2013-11-05 Thread Mike Duigou
Thanks for looking into this issue! I tried the patch and it worked correctly for me and the code looks good. I've been using only Major.Minor version numbering for recent updates. This fix seems worthy of being "25.1" Mike On Nov 5 2013, at 06:10 , Magnus Ihse Bursie wrote: > Bug: https://

Re: Removal of the old build system, partial and preliminary review (part 3)

2013-11-05 Thread Mike Duigou
On Nov 5 2013, at 06:10 , Magnus Ihse Bursie wrote: > On 2013-11-04 18:47, Phil Race wrote: >> I had this problem recently and I don't think you need restore the files - >> just the directory. >> I used hg mv to relocate the files but because *all* files were moved out >> of the directory so

Re: Help: jdk/make/common/shared/Defs.gmk:563: *** "ERROR: Trouble with the absolute path for OUTPUTDIR '

2013-11-05 Thread Francis ANDRE
Mike Le 05/11/2013 07:16, Mike Duigou a écrit : Hi Using a fresh copy of the jdk7u repository, and running make -d sanity, I got the error below. Why OUTPUTDIR must be absolute or if it must be absolute, why it is not when running make sanity? In general, using absolute paths always helps for

Re: RFR: JDK-8027698: Platform specific jars are not being signed by the sign-jars target

2013-11-05 Thread Bradford Wetmore
On 11/5/2013 1:31 AM, Erik Joelsson wrote: On 2013-11-04 20:57, Bradford Wetmore wrote: Hi Erik, Thanks for the update! Looks good, but one minor comment: SignJars.gmk 78:100:106:111-116 > 80 chars per line. Thanks. We have not enforced 80 chars in any other file in the new bu

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread Mike Duigou
One final set of changes was required based upon cross platform testing. The revised webrev which passes cross platform testing on all platforms is here: http://cr.openjdk.java.net/~mduigou/JDK-8015068/3/webrev/ The changes are: - I had to switch to using uname -s because Solaris doesn't suppor

Re: Help: jdk/make/common/shared/Defs.gmk:563: *** "ERROR: Trouble with the absolute path for OUTPUTDIR '

2013-11-05 Thread Mike Duigou
On Nov 5 2013, at 09:37 , Francis ANDRE wrote: > Mike > Le 05/11/2013 07:16, Mike Duigou a écrit : >>> Hi >>> >>> Using a fresh copy of the jdk7u repository, and running make -d sanity, I >>> got the error below. Why OUTPUTDIR must be absolute or if it must be >>> absolute, why it is not whe

hg: jdk8/build/corba: 4 new changesets

2013-11-05 Thread david . katleman
Changeset: 52ad44f9a3ec Author:alanb Date: 2013-10-22 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/52ad44f9a3ec 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks Contributed-by: alan.bate...@oralce.com, mark.sh

hg: jdk8/build/hotspot: 4 new changesets

2013-11-05 Thread david . katleman
Changeset: e39b138b2518 Author:acorn Date: 2013-10-19 18:32 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e39b138b2518 8026893: Push 8026365 to TL early and add test Reviewed-by: dcubed, kamg ! src/share/vm/classfile/verifier.cpp ! test/TEST.groups + test/runtime/802

hg: jdk8/build/jaxp: 5 new changesets

2013-11-05 Thread david . katleman
Changeset: 390e94b9a852 Author:joehw Date: 2013-10-24 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/390e94b9a852 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb ! src/com/sun/org/apache/xalan/internal/XalanConstants.java

hg: jdk8/build: 29 new changesets

2013-11-05 Thread david . katleman
Changeset: 3dc55f0c1b6f Author:jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/jdk8/build/rev/3dc55f0c1b6f 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.las...@oracle.com ! common/autoconf/generated-configure.sh ! c

hg: jdk8/build/hotspot: 34 new changesets

2013-11-05 Thread david . katleman
Changeset: f94a9f0746d8 Author:amurillo Date: 2013-10-25 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f94a9f0746d8 8027173: new hotspot build - hs25-b57 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e64f1fe9756b Author:farvidsson Date: 2013-

hg: jdk8/build/nashorn: 28 new changesets

2013-11-05 Thread david . katleman
Changeset: b01a10c7c7c2 Author:attila Date: 2013-10-17 12:38 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/b01a10c7c7c2 8026161: Don't narrow floating-point literals in the lexer Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nas

hg: jdk8/build/langtools: 31 new changesets

2013-11-05 Thread david . katleman
Changeset: 7af634b1fc5b Author:darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java Ch

Re: Removal of the old build system, partial and preliminary review (part 3)

2013-11-05 Thread David Holmes
On 6/11/2013 12:20 AM, Magnus Ihse Bursie wrote: On 2013-11-04 12:44, Magnus Ihse Bursie wrote: Unfortunately, WebRev is not very intelligent at presenting these changes. :-( I have made modifications to files that I have also moved, but WebRev just lists these files as "New" without any refere

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread David Holmes
Hi Mike, Won't pretend I follow all the changes, but how did you get rid of the platform-specific checks in the ProblemList ? Will jtreg figure that part out for itself? Also what is the failure mode if JT_HOME is not set and jtreg is not in the path? Should we just fail in that case before

Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

2013-11-05 Thread David Holmes
Aside: but I thought I recalled that someone added Tom Rodriguez' webrev updates that handle the next/prev file etc? But now I don't see it. Example output: http://cr.openjdk.java.net/~dholmes/8027755/webrev/makefiles/CompileLaunchers.gmk.cdiff.html Thanks, David On 6/11/2013 2:50 AM, Mike Du

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread Jonathan Gibbons
On 11/05/2013 05:20 PM, David Holmes wrote: Won't pretend I follow all the changes, but how did you get rid of the platform-specific checks in the ProblemList ? Will jtreg figure that part out for itself? Yes. jtreg was updated to follow the rules in the Makefiles. Generally, there has b

Re: Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

2013-11-05 Thread Mike Duigou
I would like to but haven't had a chance. I have the source for the webrev script frequently used by the hotspot team but so far haven't attempted to merge it. Volunteers are of course welcome--I had hoped that the mainline webrev updates would be so awesome that current users of the HotSpot scr

Re: Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

2013-11-05 Thread Jonathan Gibbons
Pwrhaps we should only have one copy of the webrev script around. -- Jon On 11/05/2013 05:58 PM, Mike Duigou wrote: I would like to but haven't had a chance. I have the source for the webrev script frequently used by the hotspot team but so far haven't attempted to merge it. Volunteers are o

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread Mike Duigou
On Nov 5 2013, at 17:20 , David Holmes wrote: > Hi Mike, > > Won't pretend I follow all the changes, but how did you get rid of the > platform-specific checks in the ProblemList ? Will jtreg figure that part out > for itself? Yes. JTReg has had this ability for a while and was recently enhan

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread Mike Duigou
I have updated the webrev to backout the changes to how JT_HOME is set. This will be addressed in the next set of changes (8020779 https://bugs.openjdk.java.net/browse/JDK-8020779 and 8009683 https://bugs.openjdk.java.net/browse/JDK-8009683) which will revisit how JT_HOME is set and how the jt