Re: [7u]: help on jdk/make/common/shared/Defs-windows.gmk

2013-11-20 Thread Erik Joelsson
The way I understand it $(if $(word 2,$1) is a check for whitespace in the input parameter. It's an optimization to avoid executing cygpath when it's not needed. The MixedPath macro cannot be used if the path contains a space. It also doesn't convert to an absolute path, just replacing cygwin s

Re: RFR: JDK-8028645: [infra] purge applet demos from the Solaris distros

2013-11-20 Thread Erik Joelsson
Looks good, but one style nit. 195 $(JDK_OUTPUTDIR)/demo/nbproject/%: $(JDK_TOPDIR)/src/closed/share/demo/nbproject/% 196 $(call install-file) 197 $(CHMOD) -f ug+w $@ 198 ifeq ($(OPENJDK_TARGET_OS), solaris) 199 $(RM) -r $(JDK_OUTPUTDIR)/demo/nbproject/jfc/SwingAp

Re: RFR: Bug ID: 9007227: - make/sanity-rules.gmk:61: *** multiple target patterns. Stop

2013-11-20 Thread Erik Joelsson
We identified cygwin make's inability to handle driveletter paths as one of the big problems with the old build system when starting the build-infra work for jdk8. So we designed the new build system to not use any mixed paths to avoid this problem. The problem with driveletter paths is also st

Re: RFR: JDK-8028645: [infra] purge applet demos from the Solaris distros

2013-11-20 Thread Kumar Srinivasan
Thanks Erik, I will take care of those. Kumar On 11/20/2013 1:52 AM, Erik Joelsson wrote: Looks good, but one style nit. 195 $(JDK_OUTPUTDIR)/demo/nbproject/%: $(JDK_TOPDIR)/src/closed/share/demo/nbproject/% 196 $(call install-file) 197 $(CHMOD) -f ug+w $@ 198 ifeq ($(O

Re: [7u]: help on jdk/make/common/shared/Defs-windows.gmk

2013-11-20 Thread Francis ANDRE
Erik >>How are you invoking the build to cause this error? Are you explicitly setting ALT_OUTPUTDIR? I am invoking just: make sanity without explicitly setting ALT_OUTPUTDIR. What is the path to your workspace? FrancisANDRE@idefix /cygdrive/Z/JDK/jdk7u $ hg path default = http://hg.openjdk.ja

Re: [7u]: help on jdk/make/common/shared/Defs-windows.gmk

2013-11-20 Thread Kelly O'Hair
I remember cygwin having some goofy behaviors with upper case, e.g. for Z:/. /cygdrive/Z/ vs. /cygdrive/z/ just a thought... -kto On Nov 20, 2013, at 12:11 PM, Francis ANDRE wrote: > Erik > > >>How are you invoking the build to cause this error? Are you explicitly > >>setting ALT_OUTPUTDIR

Re: RFR: Bug ID: 9007227: - make/sanity-rules.gmk:61: *** multiple target patterns. Stop

2013-11-20 Thread Francis ANDRE
Le 20/11/2013 08:37, Ivan Krylov a écrit : I went through the exercise of building openjdk 7-8 on Windows and concur it isn't trivial. But google helps and I found very the helpful Volker's blogpost very quickly. A build system should be ideally self contained, including its documentation. Thi

Re: RFR: Bug ID: 9007227: - make/sanity-rules.gmk:61: *** multiple target patterns. Stop

2013-11-20 Thread Francis ANDRE
Hi Erik Le 20/11/2013 11:06, Erik Joelsson a écrit : We identified cygwin make's inability to handle driveletter paths as one of the big problems with the old build system when starting the build-infra work for jdk8. So we designed the new build system to not use any mixed paths to avoid this