Looks good to me.
/Erik
On 2013-12-03 19:02, Pete Brunet wrote:
Please review the following 8 to 7u backport change for the make of the
Java Access Bridge. This change was needed due to build differences
between 8 and 7u.
http://cr.openjdk.java.net/~ptbrunet/JDK-8028531/
The change has alrea
Hello Mike,
I think sed on some platforms doesn't support the [[:space:]]
expression. I tried the line on a Solaris machine and it didn't work.
/Erik
On 2013-12-04 06:16, Mike Duigou wrote:
Hello all;
This change addresses a problem discovered by Dave Pointon.
http://cr.openjdk.java.net/~m
On Wed, 2013-12-04 at 10:45 +0100, Erik Joelsson wrote:
> Hello Mike,
>
> I think sed on some platforms doesn't support the [[:space:]]
> expression. I tried the line on a Solaris machine and it didn't work.
>
> /Erik
>
I concur with you Erik, character classes are only proven to work
with/in
Oooops ,
On Wed, 2013-12-04 at 11:48 +, Dave Pointon wrote:
>
> I concur with you Erik, character classes are only proven to work
> with/in perl 5 across all platforms. I suggest that the need to parse
> whitespace can be eliminated entirely by using awk(1) with a
> field-delimiter of '=' th
On 2013-11-28 11:31, Erik Joelsson wrote:
Hello Brad,
New review posted:
http://cr.openjdk.java.net/~erikj/8027963/webrev.03/
Looks good to me.
/Magnus
On 2013-11-22 10:12, Mike Duigou wrote:
the jdk/test/Makefile is normally responsible for setting the executable flags
on those files but only does so before running the tests. If you are executing
jtreg directly then the files aren't being made executable.
Hm, are you saying jtreg is setting
On 2013-11-25 13:06, Dave Pointon wrote:
I believe that this piece of work belongs in the infrastructure in as
much as I'm merely ( :-) ) attempting to adapt the IBM JDK build and
all the accompanying niceties, more into line with the OpenJDK
approach such that the additional effort necessary to
Hiya Magnus ,
On Wed, 2013-12-04 at 15:08 +0100, Magnus Ihse Bursie wrote:
> David,
>
> Is this IBM variant of OpenJDK something that is publically available?
> If so, I'd like to take a peek at it.
>
> /Magnus
>
I have sought advice as to the public availability and will keep you
posted ...
On Dec 4 2013, at 06:06 , Magnus Ihse Bursie
wrote:
> On 2013-11-22 10:12, Mike Duigou wrote:
>> the jdk/test/Makefile is normally responsible for setting the executable
>> flags on those files but only does so before running the tests. If you are
>> executing jtreg directly then the files ar
Or maybe
tr -d '[:space:]'
???
-kto
On Dec 4, 2013, at 3:48 AM, Dave Pointon wrote:
> On Wed, 2013-12-04 at 10:45 +0100, Erik Joelsson wrote:
>> Hello Mike,
>>
>> I think sed on some platforms doesn't support the [[:space:]]
>> expression. I tried the line on a Solaris machine and it did
Looks good to me as well.
Tim
On 12/ 4/13 01:38 AM, Erik Joelsson wrote:
Looks good to me.
/Erik
On 2013-12-03 19:02, Pete Brunet wrote:
Please review the following 8 to 7u backport change for the make of the
Java Access Bridge. This change was needed due to build differences
between 8 and
On Wed, 2013-12-04 at 08:51 -0800, Kelly O'Hair wrote:
> Or maybe
>
> tr -d '[:space:]'
>
> ???
>
> -kto
>
Hmmm, not unsurprisingly, that character class usage doesn't work on
Solaris either ...
$ uname -a ; echo a b c | tr -d '[:space:]' ; echo a b c | tr -d ' '
SunOS duke.hursley.ibm.c
Mike,
Do you thing hg path default and hg path default-push is still buggy? I
think it's better to use hg when possible.
Also, you can replace part before = to just .* like
sed -n -e '/^default/s/.*=[\s\t]*\(.*\)$/\1/p'
-Dmitry
On 2013-12-04 09:16, Mike Duigou wrote:
> Hello all;
>
> This c
On Dec 4 2013, at 09:25 , Dmitry Samersoff wrote:
> Mike,
>
> Do you thing hg path default and hg path default-push is still buggy? I
> think it's better to use hg when possible.
I suspect the bug was fixed at some point (It works on the 2.2 and 1.9 versions
I tried) but I can't be certain th
So at least you find a likely cause for the issues Francis are seeing. :)
It feels a bit weird juggling around with permissions like that, but maybe
there was no clear use-case for running this from hg?
/Magnus
> 4 dec 2013 kl. 16:38 skrev Mike Duigou :
>
>
>> On Dec 4 2013, at 06:06 , Magnus
Agreed with Magnus the setting of the executable bits should be made
explicitly somewhere to avoid such error...
Francis
Le 04/12/2013 19:05, Magnus Ihse Bursie a écrit :
So at least you find a likely cause for the issues Francis are seeing. :)
It feels a bit weird juggling around with p
OK, I will revise to use a variant of this awk line.
Mike
On Dec 4 2013, at 04:28 , Dave Pointon wrote:
> Oooops ,
>
> On Wed, 2013-12-04 at 11:48 +, Dave Pointon wrote:
>
>>
>> I concur with you Erik, character classes are only proven to work
>> with/in perl 5 across all platforms. I su
It should also be the case that the tests should run if the entire test/
directory (all files and directories) were readonly, so if code is
modifying files in place or creating new files anywhere in the test
directory, that should be regarded as a Bad Thing and fixed.
-- Jon
On 12/04/2013 10
IIRC, and in case it wasn't clear from reading the responses, the
permission changes are done by the Makefiles (e.g.
jdk/test/Makefile:193), and not by JTREG itself.
I agree with Jon's comment, perhaps a .dll copy to the temporary working
directory is in order. That would save people trying t
For each DLL built I also see a DIZ file. What are those? -Pete
Hi, How do I get a debug build to create PDB debug symbol files? -Pete
There are 6 dlls in the test directory
./jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.dll
./jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.dll
./jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.dll
./jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nss3.dll
./j
22 matches
Mail list logo
