Re: BootStrapping JDK7 to Mac PCC (10.5.8)

2013-12-18 Thread Erik Joelsson
It's complaining of not being able to run: /usr/local/openjdk7-zerovm-ppc-jyeary-2012-01-18-b00/bin/java What happens if you try to run that? The last error even says the same but with "pcc" instead of "ppc" which looks like a typo. /Erik On 2013-12-17 17:42, Senusi Lewis wrote: Hello I'

Re: RFR: 8030350: Enable additional compiler warnings for GCC

2013-12-18 Thread Dave Pointon
Hiya Mike , On Tue, 2013-12-17 at 16:08 -0800, Mike Duigou wrote: > For the curious, yes, the additional checks do generate additional warnings. > ;-) > > This change is targeted at the JDK 9 repos but could be backported to JDK 8 > fairly easily/safely. > > Mike > All dev &/or build enviro

Re: RFR: 8030350: Enable additional compiler warnings for GCC

2013-12-18 Thread Dmitry Samersoff
Mike, 1. I'm not sure -Wformat-security has any value for us - it checks for case printf(string) with no extra arguments, as it can cause buffer overrun if string comes from untrusted source. 2. It's possible to shorten command line by -Wformat=2 it implies -Wformat -Wformat-nonliteral -Wforma

Re: RFR: 8030350: Enable additional compiler warnings for GCC

2013-12-18 Thread Lois Foltan
Hi Mike, We need to be careful that these options are also supported on MacOS with the clang compiler in case there is a future migration to clang for JDK 9 or higher. Thanks, Lois On 12/17/2013 7:08 PM, Mike Duigou wrote: Hello all; This is a change which enables additional compiler warn

Re: Code conventions for the build system

2013-12-18 Thread Kumar Srinivasan
Hi Magnus, Is this formalized some place ? If not it would be good to get this formalized and posted on a wiki or at http://openjdk.java.net/groups/build/ Thanks Kumar On 10/8/2013 12:40 AM, Magnus Ihse Bursie wrote: Whitespace and indentation in makefiles is a more problematic area than f

Re: How to increment JDK_MINOR_VERSION for JDK 9? -- request for review

2013-12-18 Thread Joe Darcy
On 12/16/2013 02:14 PM, Joe Darcy wrote: On 12/15/2013 09:50 PM, Joe Darcy wrote: On 12/10/2013 03:51 PM, David Katleman wrote: On 12/10/2013 3:33 PM, Joseph Darcy wrote: Hello, Looking ahead to JDK 9, a build 01 change that is needed is updating the JDK_MINOR_VERSION setting in the build f

Re: RFR: 8030350: Enable additional compiler warnings for GCC

2013-12-18 Thread Mike Duigou
On Dec 18 2013, at 05:48 , Dave Pointon wrote: > Hiya Mike , > > On Tue, 2013-12-17 at 16:08 -0800, Mike Duigou wrote: > >> For the curious, yes, the additional checks do generate additional warnings. >> ;-) >> >> This change is targeted at the JDK 9 repos but could be backported to JDK 8 >

Re: RFR: 8030350: Enable additional compiler warnings for GCC

2013-12-18 Thread Mike Duigou
In response to feedback from Dmitry and Christian I have updated the webrev: http://cr.openjdk.java.net/~mduigou/JDK-8030350/1/webrev/ to now use the -Wformat=2 option and to also enable the option for BSD builds. Thanks, Mike On Dec 17 2013, at 16:08 , Mike Duigou wrote: > Hello all; > > T

Re: Hotspot makefile conversion now in build-infra

2013-12-18 Thread David Holmes
Hi Magnus, Slowly catching up after vacation ... I'm surprised this hasn't gone out to hotspot-dev as I would think hotspot developers would be most interested in this and provide feedback. But perhaps you are not quite ready for that? Will this still allow a hotspot repo to be built in isol

TOOLCHAIN_FIND_COMPILER removing symlinks?

2013-12-18 Thread Mike Duigou
I am working with a compiler toolchain that packages it's C and C++ compilers in a single executable and then uses symbolic links to disambiguate which function is being requested. Want C? Invoke a symbolic link. Want C++? Invoke a different symbolic link. Same story with it's linkers. Anyway

Re: How to increment JDK_MINOR_VERSION for JDK 9? -- request for review

2013-12-18 Thread David Holmes
Joe, hotspot/make/hotspot_version also defines: JDK_MAJOR_VER=1 JDK_MINOR_VER=8 JDK_MICRO_VER=0 David H. - On 19/12/2013 4:19 AM, Joe Darcy wrote: On 12/16/2013 02:14 PM, Joe Darcy wrote: On 12/15/2013 09:50 PM, Joe Darcy wrote: On 12/10/2013 03:51 PM, David Katleman wrote: On 12/10/2