Hello Naoto,
Looks fine from a build perspective.
The logic of that makefile is quite hairy to begin with.
/Erik
On 2014-02-05 03:54, Naoto Sato wrote:
Hello,
Please review this fix:
http://cr.openjdk.java.net/~naoto/8027289/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8027289
The f
This is likely caused by the logger shell scrip wrapper that we use to
catch the build output to a file. You can disable logging with
LOG=nofile, maybe that will make signals reach the java process.
/Erik
On 2014-02-05 06:55, Mike Duigou wrote:
Hello all;
I've noticed that I can't seem to us
On 2014-02-04 19:14, Martin Buchholz wrote:
Sure, the real world is very messy, and in practice one often ends up
writing tests that looks like "are we using gcc on macosx?" but the
goal is to have an overall portable codebase, one that has a chance of
building out of the box on a system you'v
Hi all,
This patch is for fixing a build issue with OpenJDK autoconf files. If the
--with-alsa option is used to point the build to the ALSA library from a
specific directory instead of using the system default location, the JDK
component will fail to build due to an incorrect -l parameter bein
Hi Jessica,
The attached patch was stripped by the mailing list server. Please paste
the patch inline in the mail, or provide a link to a web site with the
patch.
/Magnus
On 2014-02-05 11:09, Man, Jessica wrote:
Hi all,
This patch is for fixing a build issue with OpenJDK autoconf files. If
Thank you Magnus. Here is the patch:
# HG changeset patch
# User Jessica Man
# Date 1391463887 0
# Mon Feb 03 21:44:47 2014 +
# Node ID 7ddb4db0e9ec3ce3d924cd51d6edee5b0258adf2
# Parent 135f0c7af57ebace31383d8877f47e32172759ff
Build fails if --with-alsa option is used due to incorrect A
Hello Jessica,
If you attached the patch to your mail, the openjdk mail list server
probably removed it. If the change is small, you can post it inline in
the mail, but normally we upload a webrev on a public webserver and link
it in the mail.
/Erik
On 2014-02-05 11:09, Man, Jessica wrote:
Hello,
This change is intended for jdk8u (and jdk9).
Webrev: http://cr.openjdk.java.net/~erikj/8033210/webrev.root.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8033210
Background:
In make/common/JavaCompilation.gmk, in the macro SetupJavaCompilation,
we use the (new) -h feature in javac,
Hi Jessica,
The patch looks fine. Thank you for finding this issue and posting a patch!
I believe such trivial changes can be accepted without the hassle of you
signing the OCA, but I need to verify that.
/Magnus
On 2014-02-05 11:20, Man, Jessica wrote:
Thank you Magnus. Here is the patch:
Looks good to me.
/Magnus
On 2014-02-05 11:35, Erik Joelsson wrote:
Hello,
This change is intended for jdk8u (and jdk9).
Webrev: http://cr.openjdk.java.net/~erikj/8033210/webrev.root.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8033210
Background:
In make/common/JavaCompilation.gmk, in
Great, thank you Magnus.
I have signed the OCA,
http://www.oracle.com/technetwork/community/oca-486395.html#g under Goldman
Sachs.
-Original Message-
From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
Sent: 05 February 2014 10:40
To: Man, Jessica [Tech]; 'build-dev@openjdk
Hello,
Please review this small fix for a build break in the profiles target
caused by JDK-8026773. In that bug I missed changing a reference to the
interim javac to use the new spec variable for it.
Webrev: http://cr.openjdk.java.net/~erikj/8033680/webrev.jdk.01/
Bug: https://bugs.openjdk.ja
On 05/02/2014 12:39, Erik Joelsson wrote:
Hello,
Please review this small fix for a build break in the profiles target
caused by JDK-8026773. In that bug I missed changing a reference to
the interim javac to use the new spec variable for it.
Webrev: http://cr.openjdk.java.net/~erikj/8033680/
Looks good to me. Did you grep the code for more instances?
/Magnus
> On 5 feb 2014, at 13:39, Erik Joelsson wrote:
>
> Hello,
>
> Please review this small fix for a build break in the profiles target caused
> by JDK-8026773. In that bug I missed changing a reference to the interim
> javac t
* Andrew Hughes [2014-02-04 19:26]:
> > On 2014-02-03 18:43, Omair Majid wrote:
> > > The following webrevs modify the build system to allow building against
> > > the system-installed copy of libpng as well as using the bundled copy of
> > > libpng
> > >
> > > ROOT: http://cr.openjdk.java.net/~om
Hi Erik
Looks good to me as well.
Tim
Looks good to me.
/Magnus
On 2014-02-05 11:35, Erik Joelsson wrote:
Hello,
This change is intended for jdk8u (and jdk9).
Webrev: http://cr.openjdk.java.net/~erikj/8033210/webrev.root.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8033210
Backgrou
This code review request is going to three different aliases.
Don't use Thunderbird's "reply to list" option since it will
pick just _one_ of the _three_ lists.
Greetings,
Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS)
makefile fix our way. Here are the bug and webrev URLs:
Dan
The changes look good
Ron
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Wednesday, February 05, 2014 4:21 PM
> To: hotspot-runtime-...@openjdk.java.net;
> serviceability-...@openjdk.java.net; build-dev;
> Doug Simon; Tom Rodriguez
> Subject: code review round 0 for minor
Ron,
Thanks for the review.
Dan
On 2/5/14 7:04 PM, Ron Durbin wrote:
Dan
The changes look good
Ron
-Original Message-
From: Daniel D. Daugherty
Sent: Wednesday, February 05, 2014 4:21 PM
To: hotspot-runtime-...@openjdk.java.net; serviceability-...@openjdk.java.net;
build-dev;
Doug
Hi Dan,
Looks good to me. (I never run the install targets :( )
Thanks,
David
On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
This code review request is going to three different aliases.
Don't use Thunderbird's "reply to list" option since it will
pick just _one_ of the _three_ lists.
Gree
20 matches
Mail list logo
