Dan,
On 2014-02-14 00:29, Daniel D. Daugherty wrote:
> http://cr.openjdk.java.net/~ehelin/8033580/webrev.01/
make/Makefile
+ ifeq ($(OSNAME), bsd)
+$(RM) -rf $(EXPORT_SERVER_DIR)/libjvm.dylib.dSYM
The above needs to be:
ifeq ($(OS_VENDOR), Darwin)
$(RM
> http://cr.openjdk.java.net/~ehelin/8033580/webrev.03/
make/Makefile
No comments.
Makefile style question:
Since all this ifeq(...) logic is around Makefile rules,
should the rules themselves be indented by one tab or by
one tab and some number of spaces.
I scrolled around
* Andrew Hughes [2014-02-13 23:59]:
> As I said in the previous e-mail, the minimum I'd be happy with is if
> the current patch was updated so settings weren't being hardcoded into
> the makefiles. Passing them from configure would be sufficient for now,
> then it can be replaced by PKG_CONFIG.
H
On 02/13/2014 12:41 AM, Magnus Ihse Bursie wrote:
Henry,
- Do we want to allow convention name cc and CC and detect what it
is or simply ask for explicit choice as it is imeplemted now?
Although I don't think it's likely for a system to install, say
gcc, as cc instead of create a symbolic link
Hello all;
This is a small cleanup patch with provides better summary help output for
reconfigure and dry-run configurations.
http://cr.openjdk.java.net/~mduigou/JDK-8034979/0/webrev/
I do note that even though no configuration is created/updated in "--no-create"
mode the output directory is c
