Hi compiler-dev + build-dev,
Please review the fix for JDK-8035063 and JDK-8037085 which involves changes to
sjavac (option handling) and dev/ + dev/jdk build files.
Description:
- Sjavac relied on passing around the main arg array to whatever part of the
code that were potentially affected b
Hello,
The input from our makefiles changes from "-i some.package" to "-i
some/package/*". IIRC the include flag works recursively for sub
packages. Will the single * do the same?
/Erik
On 2014-03-19 09:49, Andreas Lundblad wrote:
Hi compiler-dev + build-dev,
Please review the fix for JDK-
On Wed, Mar 19, 2014 at 10:03:33AM +0100, Erik Joelsson wrote:
> Hello,
>
> The input from our makefiles changes from "-i some.package" to "-i
> some/package/*". IIRC the include flag works recursively for sub
> packages. Will the single * do the same?
>
> /Erik
That's strange. What used to be "
On 03/18/2014 06:22 PM, Andrew Hughes wrote:
> The intent was for #3 to cover this case (i.e. whatever Oracle does now)
> and for #2 to be what the GNU/Linux distributions want (i.e. binaries with
> all debuginfo generated and left intact so they can do their own stripping).
Mmm, but maybe that wi
Ah, I see now, it was "-i some.package.*" in the original code. Build
part looks good to me now.
/Erik
On 2014-03-19 11:17, Andreas Lundblad wrote:
On Wed, Mar 19, 2014 at 10:03:33AM +0100, Erik Joelsson wrote:
Hello,
The input from our makefiles changes from "-i some.package" to "-i
some/pa
The serviceability libraries (as defined by
jdk/make/lib/ServiceabilityLibraries.gmk) should be compiled with "warnings as
errors". To enable this all current warnings need to be fixed.
The background for this is that we recently had a bug that could have easily
been avoided if we had paid att
On 2014-03-19 13:30, Staffan Larsen wrote:
The serviceability libraries (as defined by jdk/make/lib/ServiceabilityLibraries.gmk)
should be compiled with "warnings as errors". To enable this all current
warnings need to be fixed.
The background for this is that we recently had a bug that could
Hello,
Nice work! Removing warnings and enforcing them is definitely something
we like.
For the makefile change, ideally the new variable WARNINGS_ARE_ERRORS
should be set in configure. I would suggest flags.m4, in
FLAGS_SETUP_COMPILER_FLAGS_MISC. Also, instead of making the conditional
on
On Wed, Mar 19, 2014 at 01:58:21PM +0100, Fredrik Öhrström wrote:
> The code by itself looks good. However I think that changing from . to / is
> a really bad idea.
>
> If someone committed a package directory that does not map correctly to the
> package name, then that is a major problem. You wil
On 2014-03-18 19:25, Andrew Haley wrote:
On 03/18/2014 06:22 PM, Andrew Hughes wrote:
The intent was for #3 to cover this case (i.e. whatever Oracle does now)
and for #2 to be what the GNU/Linux distributions want (i.e. binaries with
all debuginfo generated and left intact so they can do their o
On 2014-03-19 09:49, Andreas Lundblad wrote:
Hi compiler-dev + build-dev,
Please review the fix for JDK-8035063 and JDK-8037085 which involves changes to
sjavac (option handling) and dev/ + dev/jdk build files.
The build part looks good to me.
/Magnus
I should fill in that the background for this change is that there are a
bunch of directories named "doc-files" in the classes source dir. They
have been there a long time. These contain html and gif files (mainly)
that shouldn't get copied into the output classes directory.
In a recent cleanu
Erik, Magnus,
Thanks for the quick looks. Here is an updated version that adds the new
variable to flags.m4 instead.
http://cr.openjdk.java.net/~sla/8037825/webrev.01/root/
http://cr.openjdk.java.net/~sla/8037825/webrev.01/jdk/
Thanks,
/Staffan
On 19 mar 2014, at 14:03, Erik Joelsson wrote:
The code by itself looks good. However I think that changing from . to / is
a really bad idea.
If someone committed a package directory that does not map correctly to the
package name, then that is a major problem. You will not find that source
through -sourcepath, which means that you just broke
On 03/19/2014 01:51 PM, Magnus Ihse Bursie wrote:
> On 2014-03-18 19:25, Andrew Haley wrote:
>> On 03/18/2014 06:22 PM, Andrew Hughes wrote:
>>> The intent was for #3 to cover this case (i.e. whatever Oracle does now)
>>> and for #2 to be what the GNU/Linux distributions want (i.e. binaries with
>>
- Original Message -
> On 03/19/2014 01:51 PM, Magnus Ihse Bursie wrote:
> > On 2014-03-18 19:25, Andrew Haley wrote:
> >> On 03/18/2014 06:22 PM, Andrew Hughes wrote:
> >>> The intent was for #3 to cover this case (i.e. whatever Oracle does now)
> >>> and for #2 to be what the GNU/Linux
On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote:
While we generally support moving files to a proper location, if this
move is causing trouble for Phil and the 2d team, we think it can be
an acceptable exception this time to just single out the LCMS.c file.
(This can be achieved by setting INC
On 19 mar 2014, at 17:47, Erik Joelsson wrote:
> Build part looks good!
Thanks.
>
> Don't forget to push the closed generated configure.
I would have forgotten…
/Staffan
>
> /Erik
>
> On 2014-03-19 15:20, Staffan Larsen wrote:
>> Erik, Magnus,
>>
>> Thanks for the quick looks. Here is a
Build part looks good!
Don't forget to push the closed generated configure.
/Erik
On 2014-03-19 15:20, Staffan Larsen wrote:
Erik, Magnus,
Thanks for the quick looks. Here is an updated version that adds the new
variable to flags.m4 instead.
http://cr.openjdk.java.net/~sla/8037825/webrev.01
Hi,
* Phil Race [2014-03-19 12:39]:
> On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote:
> >While we generally support moving files to a proper location, if
> >this move is causing trouble for Phil and the 2d team, we think it
> >can be an acceptable exception this time to just single out the
> >LCM
Hello all;
This is a patch which adds support for the "serve" command to hgforest as well
as providing --quiet and --verbose options.
The serve command is particularly useful for sharing repos with virtual
machines used for building/testing. Using "serve" is generally faster and has
fewer prob
21 matches
Mail list logo
