On 2014-03-18 18:26, Volker Simonis wrote:
Done. Please see the new webrev at:
http://cr.openjdk.java.net/~simonis/webrevs/8037298_3/
Looks good to me.
Thanks. Could you please push this change for me because it requires
the regeneration of generated-configure.sh and potentially also the
rege
On 2014-03-22 20:11, Omair Majid wrote:
Thanks. I wasn't sure how an empty value might be processed.
Make can't really see the difference between an unassigned variable and
one assigned to nothing. (Or, it can, but it's more tricky to check). In
all the SetupFoo macros, assigning an empty valu
On 2014-03-20 17:39, Mike Duigou wrote:
I found this:
# XXX mduigou I can't figure out how to make the root repo the serve "/" root.
Is this something that ought to be fixed?
I wish I knew how. Despite fiddling with it extensively I was unable to
convince hg to serve the top repo from
http:
This bug was triggered by the issue in JDK-8035725. Had the VS detection
logic been more transparent, that bug would not have had to happen.
We need to rewrite the VS detection so that it is much more controlled,
and do not run an unchecked shell script that modifies arbitrary
environment vari
On 2014-03-21 10:36, Dmitry Samersoff wrote:
(c) Compression mode:
1. none
2. per-section compression, SHF_GNU_COMPRESSED [1]
3. zip entire file
Is 2 something we're doing? I couldn't find any references to it in the
code. Or is it something we're planning to do?
/Magnus
I think it looks good overall and it's good to clean this up.
toolchain_windows.m4:
204: not your change but the typo stings my eyes and could be fixed
while in the area. (corrent?)
I wonder if it would be better to move the deletion of the temporary
script files to later in the function so t
On 2014-03-21 09:57, David Holmes wrote:
And while, technically, you can save symbols externally, and at the same
time keep them in the binary, that does not make sense. So, in a
practical sense, you are going to do #2 if you are going to do #3.
But you can vary what is kept internally indepe
On 2014-03-24 12:20, Erik Joelsson wrote:
I think it looks good overall and it's good to clean this up.
toolchain_windows.m4:
204: not your change but the typo stings my eyes and could be fixed
while in the area. (corrent?)
Fixed.
I wonder if it would be better to move the deletion of the tem
Hi,
builds and runs on ppc linux be / aix.
Best regards,
Goetz.
-Original Message-
From: Alexander Smundak [mailto:asmun...@google.com]
Sent: Monday, March 24, 2014 9:10 PM
To: David Holmes
Cc: Lindenmaier, Goetz; build-dev; HotSpot Open Source Developers
Subject: Re: RFR (M): 8036767
Hi Magnus
Looks good to me as well.
Tim
On 03/24/14 04:20, Erik Joelsson wrote:
I think it looks good overall and it's good to clean this up.
toolchain_windows.m4:
204: not your change but the typo stings my eyes and could be fixed
while in the area. (corrent?)
I wonder if it would be bett
10 matches
Mail list logo
