Re: RFR: 8039411 : Add environment variable support to fixpath

2014-04-09 Thread Mike Duigou
On Apr 8 2014, at 03:43 , Dave Pointon wrote: > On Mon, 2014-04-07 at 14:53 -0700, Mike Duigou wrote: >> Hello all; >> >> http://cr.openjdk.java.net/~mduigou/JDK-8039411/0/webrev/ >> >> Mike > > Hiya Mike , > > My, you _were_ busy :-) > > Given that I'm not formally a reviewer, nor indeed,

RFR 8030011: Update Hotspot version string output

2014-04-09 Thread Alejandro E Murillo
Please review this change to make the hotspot related output produced by "java -version" match the corresponding JDK output: webrev: http://cr.openjdk.java.net/~amurillo/9/8030011/ Bug: https://bugs.openjdk.java.net/browse/JDK-8030011 Note that we initially wanted to obtain more information f

JDK 9 RFR of JDK-8039865: Add fallthrough lint warning to build of jdk repository

2014-04-09 Thread Joe Darcy
Hello, There are a relatively small number of "fallthrough" lint warnings in the sources of the JDK 9 jdk repo. Once those warnings are cleared (JDK-8039501), the fallthough lint option should be added to the build: diff -r f1cc18a769e5 make/Setup.gmk --- a/make/Setup.gmkTue Apr 08 17:36:

Re: RFR 8030011: Update Hotspot version string output

2014-04-09 Thread David Holmes
Hi Alejandro, Given we have to maintain the JDK version information in two places (top level repo and hotspot repo) wouldn't it have been simpler to keep hotspot_version file and HOTSPOT_RELEASE_VERSION and simply set the major/minor/build values to match those of the JDK version? That aside

Re: JDK 9 RFR of JDK-8039865: Add fallthrough lint warning to build of jdk repository

2014-04-09 Thread Erik Joelsson
Looks good. /Erik On 2014-04-10 03:43, Joe Darcy wrote: Hello, There are a relatively small number of "fallthrough" lint warnings in the sources of the JDK 9 jdk repo. Once those warnings are cleared (JDK-8039501), the fallthough lint option should be added to the build: diff -r f1cc18a769