Hi David, thanks for the feedback, see below
On 4/9/2014 8:38 PM, David Holmes wrote:
Hi Alejandro,
Given we have to maintain the JDK version information in two places
(top level repo and hotspot repo) wouldn't it have been simpler to
keep hotspot_version file and HOTSPOT_RELEASE_VERSION and s
Sometimes I get a little confused/nervous when trying to push/status/in using
the hgforest.sh script. The output can be a little confusing as it runs several
jobs in parallel.
I would like to add an option to support sequential operation of commands. It
is off by default. The more nervous of us
Vote: yes
-phil.
Looks good to me and useful. (Other than that I had hoped to claim "-s" for a
future change I planned ;-) (no worries, I will use "-r" for that))
Mike
On Apr 10 2014, at 08:54 , Chris Hegarty wrote:
> Sometimes I get a little confused/nervous when trying to push/status/in using
> the hgfores
On 10 Apr 2014, at 20:03, Mike Duigou wrote:
> Looks good to me and useful. (Other than that I had hoped to claim "-s" for
> a future change I planned ;-) (no worries, I will use "-r" for that))
Thanks for the review Mike. If you want to keep ‘-s’ we can come up with
something else, “—np|—no
On Apr 8 2014, at 23:26 , Erik Joelsson wrote:
> Indentation look weird around line 460 and 470 (tab vs space?), otherwise
> it's ok to me.
Corrected before push. Some text editor I was using was allowing tabs to sneak
in.
Mike
>
> /Erik
>
> On 2014-04-08 21:31, Mike Duigou wrote:
>> I hav
On 11/04/2014 1:42 AM, Alejandro E Murillo wrote:
Hi David, thanks for the feedback, see below
On 4/9/2014 8:38 PM, David Holmes wrote:
Hi Alejandro,
Given we have to maintain the JDK version information in two places
(top level repo and hotspot repo) wouldn't it have been simpler to
keep hotsp
