On 2014-04-15 18:41, Mike Duigou wrote:
I am curious why you didn't make it conditional based upon DEBUG_LEVEL like jdk
and corba? It would be difficult/annoying to turn it on if needed.
But it is. If debug level is set to something debug, configure sets
JAVAC_FLAGS to -g and this gets picked
Looks good to me.
/Erik
On 2014-04-15 22:30, Mike Duigou wrote:
[fix missing title]
On Apr 15 2014, at 13:30 , Mike Duigou wrote:
Hello all;
The recent change to fixpath in JDK-8039411
(https://bugs.openjdk.java.net/browse/JDK-8039411)
(http://hg.openjdk.java.net/jdk9/dev/rev/45183b39d30
Fix looks good to me.
Noticed this:
> while ((blocklen = fread(block,1,sizeof(block),atin)) > 0) {
Maybe add some space after the commas, if you are fixing other formatting
issues?
/Magnus
> On 15 apr 2014, at 22:30, Mike Duigou wrote:
>
> [fix missing title]
>
>> On Apr 15 2014, at 13:30 ,
Hello Amanda,
I suspect there is something weird in your environment that makes the
variable extraction from the visual studio setup bat file fail. Could
you paste the contents of the file /set-vs-env.sh?
/Erik
On 2014-04-16 01:43, Amanda Jiang wrote:
Hi Volker,
A more detailed log from co
On 2014-04-16 09:14, Erik Joelsson wrote:
On 2014-04-15 18:41, Mike Duigou wrote:
I am curious why you didn't make it conditional based upon
DEBUG_LEVEL like jdk and corba? It would be difficult/annoying to
turn it on if needed.
But it is. If debug level is set to something debug, configure s
The previous RFR tried to solve both this simple problem and the larger
rewrite of the options but seems to be stalled due to problems with the
Windows build. Since it is very inconvenient to have a broken sjavac in
jdk9/jdk9, perhaps someone within Oracle could take this simple patch
(almost ident
There are now changes in jdk9 which prohibit the use of jdk7 as boot jdk
(unless the update version is high enough). It's time we formally change
the requirement from jdk7 to jdk8 by making configure require it.
Bug: https://bugs.openjdk.java.net/browse/JDK-8030794
Patch:
diff -r 1dfbd8aa5d3d
Looks good to me.
-Chris.
On 16/04/14 11:01, Erik Joelsson wrote:
There are now changes in jdk9 which prohibit the use of jdk7 as boot jdk
(unless the update version is high enough). It's time we formally change
the requirement from jdk7 to jdk8 by making configure require it.
Bug: https://bug
Looks good to me as well.
Tim
On 04/16/14 10:07, Chris Hegarty wrote:
Looks good to me.
-Chris.
On 16/04/14 11:01, Erik Joelsson wrote:
There are now changes in jdk9 which prohibit the use of jdk7 as boot jdk
(unless the update version is high enough). It's time we formally change
the requi
Looks good!
Mike
On Apr 16 2014, at 01:07 , Erik Joelsson wrote:
>
> On 2014-04-16 09:14, Erik Joelsson wrote:
>>
>> On 2014-04-15 18:41, Mike Duigou wrote:
>>> I am curious why you didn't make it conditional based upon DEBUG_LEVEL like
>>> jdk and corba? It would be difficult/annoying to tu
Thanks!
I will add additional spaces after commas before pushing the changeset.
Mike
On Apr 16 2014, at 00:24 , Magnus Ihse Bursie
wrote:
> Fix looks good to me.
>
> Noticed this:
>> while ((blocklen = fread(block,1,sizeof(block),atin)) > 0) {
> Maybe add some space after the commas, if you
HI Erik,
Thanks for replying, below are contents of set-vs-env.sh
$ cat set-vs-env.sh
VS_PATH="/cygdrive/c/Program Files (x86)/Microsoft Visual Studio
10.0/VSTSDB/Deploy:/cygdrive/c/Program Files (x86)/Microsoft Visual
Studio 10.0/Common7/IDE:/cygdrive/c/Program Files (x86)/Microsoft Visual
S
On 16 apr 2014, at 21:00, Amanda Jiang wrote:
>
> VS_INCLUDE=" "
> VS_LIB=" "
These should not be empty. It is the cause of your failures. The question is
why they are empty, though...
/Magnus
When this is changeset is pushed please send message out to jdk9-dev to inform
everyone that the change has been made. Will you be pushing it to jdk9/dev or
jdk9/build?
Mike
On Apr 16 2014, at 03:01 , Erik Joelsson wrote:
> There are now changes in jdk9 which prohibit the use of jdk7 as boot
14 matches
Mail list logo
