Re: How to set build version

2014-08-22 Thread Erik Joelsson
Hello, From what I can tell, you are doing it right. Did you do a clean build after you reran configure? Changing the version information does not correctly trigger an incremental build of all uses of the version information. /Erik On 2014-08-22 03:13, Medi Montaseri wrote: Trying build-de

Re: Build summary UX

2014-08-22 Thread Erik Joelsson
On 2014-08-22 01:10, Martin Buchholz wrote: Serial execution is useful for both resource-constrained environments and for folks trying to profile the build itself. Serial build is also likely to be optimal if you are optimizing for total energy used rather than total wall clock time. If you

Re: Build summary UX

2014-08-22 Thread Erik Joelsson
On 2014-08-22 01:35, Jonathan Gibbons wrote: I like the new finer grained parallelism in general (builds are faster), but I do find the default output more confusing because it is harder to see the warning messages go rushing past. I agree that this is a problem. It can be partially mitigated

Update compiler workarounds for Clang 6.0

2014-08-22 Thread Alexander Scherbatiy
Hi, I got the following message during building the JDK 9 on Mac OS X 10.10 Yosemity: Compiling 32 properties into resource bundles /Users/alexsch/openjdk/jdk9-modules/hotspot/make/bsd/makefiles/gcc.make:329: *** "Update compiler workarounds for Clang 6.0". Stop.

Re: Build summary UX

2014-08-22 Thread Aleksey Shipilev
Hi Erik, Thanks for the explanations, comments below: On 08/21/2014 07:39 PM, Erik Joelsson wrote: > As I have tried to explain a couple of times now: The jdk8 build built > each repository in sequence (much like the jdk7 build did). Because of > this it made sense to add messages about which rep

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

2014-08-22 Thread Erik Joelsson
Hello, Looks ok from me too. /Erik On 2014-08-21 19:43, Daniel D. Daugherty wrote: > http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/ make/solaris/Makefile No comments. make/solaris/makefiles/buildtree.make No comments. A product build with the above changes shows this: $ ca

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

2014-08-22 Thread Jesper Wilhelmsson
Thanks Erik! /Jesper Erik Joelsson skrev 22/8/14 13:02: Hello, Looks ok from me too. /Erik On 2014-08-21 19:43, Daniel D. Daugherty wrote: > http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/ make/solaris/Makefile No comments. make/solaris/makefiles/buildtree.make No comments.

Re: RFR: 8014510: Fix sjavac on all platforms in jprt

2014-08-22 Thread Erik Joelsson
Thanks for looking into this. I took the liberty of tuning this some more and finally arrived at this set of changes: http://cr.openjdk.java.net/~erikj/8014510/webrev.root.01/ First of all I wanted to get rid of the big if-else construct, so I changed that into a simple MEMORY_SIZE/2 for sjava

Re: "make profiles" doesn't seem to work on jdk8u

2014-08-22 Thread Erik Joelsson
I tried to reproduce this but my build succeeded. I know there was a lot of trickery to getting the escaping working for all the $$ chars. /Erik On 2014-08-21 19:17, Andrew Haley wrote: $ sh ./configure --with-debug_level=slowdebug --disable-zip-debug-info $ CONF=linux-x86_64-normal-server-slo

Re: Update compiler workarounds for Clang 6.0

2014-08-22 Thread Staffan Larsen
I have filed https://bugs.openjdk.java.net/browse/JDK-8048298 to track this. It includes a patch to workaround it. /Staffan > On 22 aug 2014, at 12:16, Alexander Scherbatiy > wrote: > > > Hi, > > I got the following message during building the JDK 9 on Mac OS X 10.10 > Yosemity: >

RE: How to set build version

2014-08-22 Thread Medi Montaseri
Thanks Erik, I was playing with a dirty pipetmake clean did the job Medi From: Erik Joelsson [erik.joels...@oracle.com] Sent: Friday, August 22, 2014 2:59 AM To: Medi Montaseri; build-dev@openjdk.java.net Subject: Re: How to set build version Hello,

RFR (XS) JDK-8054355: ENFORCE_CC_COMPILER_REV needs to be updated to Solaris C++ 12u3 for JDK 9

2014-08-22 Thread Lois Foltan
Hi Everyone, Please review the following fix: Webrev: http://cr.openjdk.java.net/~lfoltan/bug_jdk8054355/ Bug: ENFORCE_CC_COMPILER_REV needs to be updated to Solaris C++ 12u3 for JDK 9 https://bugs.openjdk.java.net/browse/JDK-8054355 Summary of fix: Update of C++ validation check for

[9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-22 Thread Naoto Sato
Hello, Please review the changes for the following issue: https://bugs.openjdk.java.net/browse/JDK-8038436 The proposed changes are located at: http://cr.openjdk.java.net/~naoto/8038436/webrev.3/ The idea is to introduce an SPI so that supported locales are dynamically searched at runtime, n

Re: RFR (XS) JDK-8054355: ENFORCE_CC_COMPILER_REV needs to be updated to Solaris C++ 12u3 for JDK 9

2014-08-22 Thread Vladimir Kozlov
Good. Thanks, Vladimir On 8/22/14 11:35 AM, Lois Foltan wrote: Hi Everyone, Please review the following fix: Webrev: http://cr.openjdk.java.net/~lfoltan/bug_jdk8054355/ Bug: ENFORCE_CC_COMPILER_REV needs to be updated to Solaris C++ 12u3 for JDK 9 https://bugs.openjdk.java.net/brow

Re: Build summary UX

2014-08-22 Thread Martin Buchholz
On Fri, Aug 22, 2014 at 3:10 AM, Erik Joelsson wrote: > > On 2014-08-22 01:10, Martin Buchholz wrote: > > Serial execution is useful for both resource-constrained environments and > for folks trying to profile the build itself. Serial build is also likely > to be optimal if you are optimizing fo

Re: RFR (XS) JDK-8054355: ENFORCE_CC_COMPILER_REV needs to be updated to Solaris C++ 12u3 for JDK 9

2014-08-22 Thread Lois Foltan
Thanks Vladimir! Lois On 8/22/2014 3:01 PM, Vladimir Kozlov wrote: Good. Thanks, Vladimir On 8/22/14 11:35 AM, Lois Foltan wrote: Hi Everyone, Please review the following fix: Webrev: http://cr.openjdk.java.net/~lfoltan/bug_jdk8054355/ Bug: ENFORCE_CC_COMPILER_REV needs to be updated

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-22 Thread Mandy Chung
On 8/22/14 11:46 AM, Naoto Sato wrote: http://cr.openjdk.java.net/~naoto/8038436/webrev.3/ I skimmed on the patch and have a few initial comment/questions. JREENLocaleDataMetaInfo JRENonENLocaleDataMetaInfo - are the lists of locale names generated previously? The long lines need to be

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-22 Thread Naoto Sato
Thank you Mandy for a quick review. Please see my comments below. On 8/22/14, 2:26 PM, Mandy Chung wrote: On 8/22/14 11:46 AM, Naoto Sato wrote: http://cr.openjdk.java.net/~naoto/8038436/webrev.3/ I skimmed on the patch and have a few initial comment/questions. JREENLocaleDataMetaInfo JRENo

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-22 Thread Mandy Chung
On 8/22/14 3:37 PM, Naoto Sato wrote: I wonder ifavailableLanguageTags andgetSupportedLocaleString should return a list or an array of String (see comment below). There are two provider implementations for sun.util.locale.provider.LocaleDataMetaInfo and two service config files as yo

OpenJDK9 - build errors on Linux/Ubuntu 12.04

2014-08-22 Thread Mani Sarkar
Hi, Lately I have been getting a lot of build failures and the most recent ones are the below (snippets of the error messages from the logs): *First instance after running make images* . . . make[4]: warning: -jN forced in submake: disabling jobserver mode. INFO: ENABLE_FULL_DEBUG_SYMBOLS=1 INFO:

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-22 Thread Naoto Sato
On 8/22/14, 3:56 PM, Mandy Chung wrote: A service config file can contain multiple provider implementation classes. JDI connector is one example: http://hg.openjdk.java.net/jdk9/dev/jdk/file/74078474d9bd/src/jdk.jdi/share/classes/META-INF/services/com.sun.jdi.connect.Connector There may be som

Re: OpenJDK9 - build errors on Linux/Ubuntu 12.04

2014-08-22 Thread Martin Buchholz
I've also just lost the ability to build jdk9. I also get uninformative make[1]: *** [main-wrapper] Error 2 Trying to debug, I configure with --with-jobs=1 and run make LOG=debug and that gets me: make[3]: Entering directory `...home/martinrb/ws/9up/jdk/make' Tools.gmk:35: SetupJava.gmk: No suc

Re: RFR: JDK-8055352: AIX hprof should include its own copy of dladdr in porting_aix.c

2014-08-22 Thread Volker Simonis
Hi Erik, I'll be back in office and have a closer look at your change on Tuesday. Until then - which change moved porting_aix.* to the two new locations? It seems strange that a "modularization change" requires code duplication - that's not how I understand modularization:) Regards, Volker On