On 2014-09-16 23:03, Naoto Sato wrote:
I revised the fix based on suggestions from Erik/Magnus. I just ended
up creating Gensrc-jdk.localedata.gmk, instead of renaming
GensrcCLDR.gmk because GensrcLocaleData.gmk (formerly
GensrcLocaleDataMetaInfo.gmk) is also needed to build jdk.localedata:
On 2014-09-17 11:36, Erik Joelsson wrote:
On 2014-09-16 23:03, Naoto Sato wrote:
I revised the fix based on suggestions from Erik/Magnus. I just ended
up creating Gensrc-jdk.localedata.gmk, instead of renaming
GensrcCLDR.gmk because GensrcLocaleData.gmk (formerly
GensrcLocaleDataMetaInfo.gmk)
Please review this little cleanup patch for Gensrc*.gmk files.
GensrcProviders.gmk and GensrcJDWP are both short and are only used by
Gensrc-jdk.jdi.gmk, so I inlined them in that file.
Gensrc-jdk.attach.gmk was no longer doing anything so it could be removed.
I could not find any other simple
On 2014-09-17 14:59, Erik Joelsson wrote:
Please review this little cleanup patch for Gensrc*.gmk files.
GensrcProviders.gmk and GensrcJDWP are both short and are only used by
Gensrc-jdk.jdi.gmk, so I inlined them in that file.
Gensrc-jdk.attach.gmk was no longer doing anything so it could be
After looking closer, you are correct. Here is a new webrev:
http://cr.openjdk.java.net/~erikj/8055189/webrev.jdk.02/
/Erik
On 2014-09-17 15:18, Magnus Ihse Bursie wrote:
I think you can split up GensrcCharsetMapping.gmk as well, so it only
contains the java.base stuff, and inline the jdk.char
Hi Erik:
Looks good to me as well.
/Tim
After looking closer, you are correct. Here is a new webrev:
http://cr.openjdk.java.net/~erikj/8055189/webrev.jdk.02/
/Erik
On 2014-09-17 15:18, Magnus Ihse Bursie wrote:
I think you can split up GensrcCharsetMapping.gmk as well, so it only
contains
