Build support for JDK-8044627

2014-10-14 Thread Pavel Rappo
Hi, I can't build jdk9/dev repo after I introduced 4 'META-INF/service/javax.naming.spi.InitialContextFactory' files to support JNDI providers loading as a service [1]. My guess is that 'META-INF/service/javax.naming.spi.InitialContextFactory' files from different modules are being copied into

Re: Build support for JDK-8044627

2014-10-14 Thread Erik Joelsson
Hello Pavel, This will be a bit tricky. Give me a day or two and I will try to come up with something. /Erik On 2014-10-14 15:27, Pavel Rappo wrote: Hi, I can't build jdk9/dev repo after I introduced 4 'META-INF/service/javax.naming.spi.InitialContextFactory' files to support JNDI provide

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Chris Hegarty
On 14 Oct 2014, at 15:03, Pavel Rappo wrote: > OK, so what I will do for now is I exclude these 4 files and push without > them. I'll create a new issue to add them later. That sounds like a fine plan. This issue has already gone on for long enough, and I don’t think that the crooks of the cha

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Daniel Fuchs
On 14/10/14 16:09, Chris Hegarty wrote: On 14 Oct 2014, at 15:03, Pavel Rappo wrote: OK, so what I will do for now is I exclude these 4 files and push without them. I'll create a new issue to add them later. That sounds like a fine plan. This issue has already gone on for long enough, and

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Pavel Rappo
Thanks a lot! -Pavel On 14 Oct 2014, at 15:33, Chris Hegarty wrote: > META-INF files in the webrev, two of which are in the wrong location. They > are directly under 'META-INF’, where they should all be under > ‘META-INF/services’. This is just a note for Pavel, when he follows up later > wi

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-10-14 Thread Chris Hegarty
On 14 Oct 2014, at 15:15, Daniel Fuchs wrote: > On 14/10/14 16:09, Chris Hegarty wrote: >> On 14 Oct 2014, at 15:03, Pavel Rappo wrote: >> >>> OK, so what I will do for now is I exclude these 4 files and push without >>> them. I'll create a new issue to add them later. >> >> That sounds like