Re: RFR: AARCH64: Top-level JDK changes

2014-11-19 Thread Erik Joelsson
On 2014-11-18 19:09, Christian Thalinger wrote: On Nov 18, 2014, at 7:36 AM, Magnus Ihse Bursie wrote: On 2014-11-18 01:59, Christian Thalinger wrote: On Nov 17, 2014, at 4:11 AM, Magnus Ihse Bursie wrote: On 2014-11-14 21:44, Dean Long wrote: The distribution exception is there exactly

Re: RFR: JDK-8065215 Print warning summary at end of configure

2014-11-19 Thread Tim Bell
Magnus: Warnings in configure tends to just fly by quickly and be buried in the verbose autoconf output. We could with a simple trick repeat all those warnings (if any) at the end of configure, where they will be more easily spotted. Bug: https://bugs.openjdk.java.net/browse/JDK-8065215 Web

Re: RFR: AARCH64: 8064357: Top-level JDK changes

2014-11-19 Thread Andrew Haley
I think this covers everything that reviewers have mentioned: http://cr.openjdk.java.net/~aph/aarch64-8064357-4/ Andrew.

Re: RFR(M): 8057538: Sponsor for back port of --with-freetype-src searched

2014-11-19 Thread Patrick Reinhart
Hi Magnus, Did you had the time to check my back port jet? Is there anything I can do to help? It would greatly improve the Adopt OpenJDK program to also having the JDK 8 built in the same ease as the JDK 9. Best regards Patrick > Am 17.11.2014 um 13:16 schrieb Patrick Reinhart : > > Hi Ma

RFR 8u40: 8065397: Remove ExtendedPlatformComponent.java from EXFILES list

2014-11-19 Thread roger riggs
Please review a cleanup for the 8u40 build. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-build-8065353/ Thanks, Roger

Re: RFR 8u40: 8065397: Remove ExtendedPlatformComponent.java from EXFILES list

2014-11-19 Thread Mandy Chung
On 11/19/2014 12:47 PM, roger riggs wrote: Please review a cleanup for the 8u40 build. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-build-8065353/ Looks okay to me. Are you also asking for 8u40 putback approval as well? Or maybe you are thinking to send a separate 8u40 request? M

[8u40] Request for approval for CR 8065397 - Remove ExtendedPlatformComponent.java from EXFILES list

2014-11-19 Thread roger riggs
With correct subject line, requesting approval for: Please review a cleanup for the 8u40 build. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-build-8065353/ Looks okay to me. Are you also asking for 8u40 putback approval as well? Or maybe you are thinking to send a separate 8u40 requ

Re: RFR: AARCH64: Top-level JDK changes

2014-11-19 Thread Christian Thalinger
> On Nov 19, 2014, at 12:56 AM, Erik Joelsson wrote: > > > On 2014-11-18 19:09, Christian Thalinger wrote: >>> On Nov 18, 2014, at 7:36 AM, Magnus Ihse Bursie >>> wrote: >>> >>> On 2014-11-18 01:59, Christian Thalinger wrote: > On Nov 17, 2014, at 4:11 AM, Magnus Ihse Bursie > wrot

Unhelpful configure error on OSX for 8u

2014-11-19 Thread David Holmes
configure:20727: The C compiler (located as /usr/bin/gcc) does not seem to be the required GCC compiler. configure:20729: The result from running with --version was: "Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/

Re: RFR: 8065138 - Encodings.isRecognizedEnconding sometimes fails to recognize 'UTF8'

2014-11-19 Thread Martin Buchholz
[+ build-dev] I think I see the problem. By default, a Unix pipeline sadly fails only when the last command fails. In bash, you can change this to a more sensible default via set -o pipefail but that's not portable enough for openjdk. $(CAT) $$< | $(SED) -e 's/\([^\\]\):/\1\\:/g' -e 's/\([^\\]\

Re: RFR: 8065138 - Encodings.isRecognizedEnconding sometimes fails to recognize 'UTF8'

2014-11-19 Thread Martin Buchholz
Amusingly, the $(SORT) has an LC_ALL=C carefully placed before it, but the $(SED)s need it too! On Wed, Nov 19, 2014 at 5:18 PM, Martin Buchholz wrote: > [+ build-dev] > > I think I see the problem. By default, a Unix pipeline sadly fails > only when the last command fails. In bash, you can cha