The custom configure additions needs to be extended with a hook right
after AC_OUTPUT.
Bug: https://bugs.openjdk.java.net/browse/JDK-8074554
Patch inlined:
diff --git a/common/autoconf/configure.ac b/common/autoconf/configure.ac
--- a/common/autoconf/configure.ac
+++ b/common/autoconf/configure
Looks good to me.
/Erik
On 2015-03-06 14:44, Magnus Ihse Bursie wrote:
The custom configure additions needs to be extended with a hook right
after AC_OUTPUT.
Bug: https://bugs.openjdk.java.net/browse/JDK-8074554
Patch inlined:
diff --git a/common/autoconf/configure.ac b/common/autoconf/confi
Please review this backport of JDK-8074554 to 8u. While it did not
automatically apply cleanly, the difference was trivially resolved.
diff --git a/common/autoconf/configure.ac b/common/autoconf/configure.ac
--- a/common/autoconf/configure.ac
+++ b/common/autoconf/configure.ac
@@ -53,6 +53,7 @@
Looks good.
/Erik
On 2015-03-06 15:09, Magnus Ihse Bursie wrote:
Please review this backport of JDK-8074554 to 8u. While it did not
automatically apply cleanly, the difference was trivially resolved.
diff --git a/common/autoconf/configure.ac b/common/autoconf/configure.ac
--- a/common/autocon
On 2015-03-05 10:25, Erik Joelsson wrote:
Hello Mandy,
The build changes look ok to me.
Build changes are OK for me too.
/Magnus
/Erik
On 2015-03-05 02:13, Mandy Chung wrote:
As listed in an open issue in JEP 200:
The jdk.dev and jdk.runtime modules contain miscellaneous tools that do
n
Requesting approval to backport this JDK9 fix to jdk8u-dev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8074554
Original JDK9 changeset:
http://hg.openjdk.java.net/jdk9/client/rev/8b9bd5ba445e
/Magnus
On 2015-03-06 15:27, Erik Joelsson wrote:
Looks good.
/Erik
On 2015-03-06 15:09, Magnus
On 2015-03-04 22:03, Martin Buchholz wrote:
I agree that configure should not mess with user's PATH and should
"auto-find" programs in /usr/ccs/bin only as a last resort.
It would be reasonable, when configure fails on Solaris, to notice that the
user does not have /usr/ccs/bin on PATH and sugge
On 2015-03-04 17:02, Jan Lahoda wrote:
Magnus, Jon,
As per your suggestions, I've split the ct.sym.txt into several files
approximately per (current) module. I've changed to format to a
baseline+change files as well. The biggest file is java.desktop
baseline (OpenJDK 7 content) which is <5MB,
Hi Severin and Omair,
Sorry for not replying to this earlier.
I agree that the handling of debug information in OpenJDK has not
properly addressed the needs of the Linux distribution community. :-(
And even if this does not really help you, I can perhaps comfort you
slightly by saying that t
Hi Magnus,
On Fri, 2015-03-06 at 16:03 +0100, Magnus Ihse Bursie wrote:
> Hi Severin and Omair,
>
> Sorry for not replying to this earlier.
>
> I agree that the handling of debug information in OpenJDK has not
> properly addressed the needs of the Linux distribution community. :-(
>
> And even
On 2015-03-06 16:11, Severin Gehwolf wrote:
Hi Magnus,
On Fri, 2015-03-06 at 16:03 +0100, Magnus Ihse Bursie wrote:
Hi Severin and Omair,
Sorry for not replying to this earlier.
I agree that the handling of debug information in OpenJDK has not
properly addressed the needs of the Linux distrib
On 2015-03-04 17:30, Alan Bateman wrote:
On 04/03/2015 15:03, Magnus Ihse Bursie wrote:
I believe all warnings are important to check! Unfortunately, this
has not been done for a lot of warnings for a lot of time. :(
Right, although in the past we had some areas close to be cleared of
warnings,
On 2015-03-04 14:31, Erik Joelsson wrote:
Hello,
Really nice to finally see this patch getting done!
Only one comment:
flags.m4:
In the grep expression, could you move the extra [] outside of the
actual command line options to grep so that the command line could be
copied to the shell for de
Magnus:
Looks good to me as well.
Tim
On 03/06/15 05:47, Erik Joelsson wrote:
Looks good to me.
/Erik
On 2015-03-06 14:44, Magnus Ihse Bursie wrote:
The custom configure additions needs to be extended with a hook right
after AC_OUTPUT.
Bug: https://bugs.openjdk.java.net/browse/JDK-8074554
Approved. Please add a suitable noreg keyword.
-Rob
On 06/03/15 14:41, Magnus Ihse Bursie wrote:
Requesting approval to backport this JDK9 fix to jdk8u-dev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8074554
Original JDK9 changeset:
http://hg.openjdk.java.net/jdk9/client/rev/8b9bd5ba44
On 03/06/15 06:50, Magnus Ihse Bursie wrote:
On 2015-03-04 22:03, Martin Buchholz wrote:
I agree that configure should not mess with user's PATH and should
"auto-find" programs in /usr/ccs/bin only as a last resort.
It would be reasonable, when configure fails on Solaris, to notice
that the
u
On Fri, Mar 6, 2015 at 6:50 AM, Magnus Ihse Bursie <
magnus.ihse.bur...@oracle.com> wrote:
> On 2015-03-04 22:03, Martin Buchholz wrote:
>
>> I agree that configure should not mess with user's PATH and should
>> "auto-find" programs in /usr/ccs/bin only as a last resort.
>>
>> It would be reasonab
> 6 mar 2015 kl. 19:58 skrev Martin Buchholz :
>
>
>
>> On Fri, Mar 6, 2015 at 6:50 AM, Magnus Ihse Bursie
>> wrote:
>>> On 2015-03-04 22:03, Martin Buchholz wrote:
>>> I agree that configure should not mess with user's PATH and should
>>> "auto-find" programs in /usr/ccs/bin only as a last r
Magnus,
You can add a generic warning:
if configure fails finding some tools and it's solaris
then
warn about /usr/ccs/bin that should be in a path
end
I'm against of altering PATH any way (appending or prepending anything)
because it might lead to the situation where wrong tool is picked and
On 7/03/2015 12:50 AM, Magnus Ihse Bursie wrote:
On 2015-03-04 22:03, Martin Buchholz wrote:
I agree that configure should not mess with user's PATH and should
"auto-find" programs in /usr/ccs/bin only as a last resort.
It would be reasonable, when configure fails on Solaris, to notice
that t
> 7 mar 2015 kl. 03:18 skrev David Holmes :
>
>
>
>> On 7/03/2015 12:50 AM, Magnus Ihse Bursie wrote:
>>> On 2015-03-04 22:03, Martin Buchholz wrote:
>>> I agree that configure should not mess with user's PATH and should
>>> "auto-find" programs in /usr/ccs/bin only as a last resort.
>>>
>>> I
> 6 mar 2015 kl. 20:17 skrev Dmitry Samersoff :
>
> Magnus,
>
> You can add a generic warning:
>
> if configure fails finding some tools and it's solaris
> then
> warn about /usr/ccs/bin that should be in a path
> end
This is exactly what I said would be technically hard to do. Much harder th
22 matches
Mail list logo
