Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Erik Joelsson
Hello Peter, The new source layout and Lib-jdk.accessibility.gmk look much better. Thanks! Regarding the .def files, I was mistaken and missed that they were referenced in the LDFLAGS, they were indeed used in the build so no reason to remove them. /Erik On 2015-03-24 22:36, Pete Brunet w

Re: RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-25 Thread David Holmes
I've been asked to make a change so a new webrev will be firthcoming. Thanks, David On 25/03/2015 1:43 PM, David Holmes wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8072740 webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev/ Simple fix, contributed by Dean Long, that allows th

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
On 3/24/15 3:23 PM, Pete Brunet wrote: > Hi Sergey, That's pretty much the case. I just went through the code > and found these differences: > - merged in JDK-8055173 (merge jawt.dll into javaaccessbridge.dll) which > was recently pushed. That should have been jawtaccessbridge.dll (not jawt.dll)

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
On 3/25/15 3:01 AM, Erik Joelsson wrote: > Hello Peter, > > The new source layout and Lib-jdk.accessibility.gmk look much better. > Thanks! > > Regarding the .def files, I was mistaken and missed that they were > referenced in the LDFLAGS, they were indeed used in the build so no > reason to remo

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Sergey Bylokhov
The fix looks fine. But it is interesting, do we have an option to remove all deprecated methods during this opening? or can we do it later? or we cannot? 25.03.15 17:44, Pete Brunet wrote: On 3/25/15 3:01 AM, Erik Joelsson wrote: Hello Peter, The new source layout and Lib-jdk.accessibility

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
Hi Sergey, Which methods are you referring to? -Pete On 3/25/15 10:16 AM, Sergey Bylokhov wrote: > The fix looks fine. > But it is interesting, do we have an option to remove all deprecated > methods during this opening? or can we do it later? or we cannot? > > 25.03.15 17:44, Pete Brunet wrote:

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Mandy Chung
On 3/24/2015 2:36 PM, Pete Brunet wrote: Here's the latest patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/ The modules.xml change looks fine. Mandy

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Phil Race
AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. The change jdk/make/copy/Copy-java.gmk suggests that accessbridge is the only reason the closed version of

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Pete Brunet
Thanks Phil, On 3/25/15 11:26 AM, Phil Race wrote: > AWTEventMonitor.java has a bunch of deprecated methods. > If you don't have time now (I expect you don't) then it can be > revisited later. Open sourcing is different than binary compatibility. These were deprecated via CCC 8007499. > > The chan

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-25 Thread Phil Race
On 3/25/2015 10:58 AM, Pete Brunet wrote: Thanks Phil, On 3/25/15 11:26 AM, Phil Race wrote: AWTEventMonitor.java has a bunch of deprecated methods. If you don't have time now (I expect you don't) then it can be revisited later. Open sourcing is different than binary compatibility. These were

Re: RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-25 Thread David Holmes
New webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev.v2/ This doesn't define the ALT_JVMCFG_SRC in the open file - which makes more sense for the clean up. I was unsure if $(wildcard xxx) would behave okay if xxx was an undefined variable, but it seems to handle it okay. Thanks,

[8u60] RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-25 Thread David Holmes
bug: https://bugs.openjdk.java.net/browse/JDK-8072740 webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev.8u/ Simple fix, contributed by Dean Long, that allows the jvm.cfg file to be located in the "closed" location. The arm and ppc jvm.cfg files can then be moved to that "closed" locat

Re: RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-25 Thread Dean Long
On 3/25/2015 3:42 PM, David Holmes wrote: New webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev.v2/ This doesn't define the ALT_JVMCFG_SRC in the open file - which makes more sense for the clean up. I was unsure if $(wildcard xxx) would behave okay if xxx was an undefined variable,

Re: RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-25 Thread David Holmes
On 26/03/2015 4:38 PM, Dean Long wrote: On 3/25/2015 3:42 PM, David Holmes wrote: New webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev.v2/ This doesn't define the ALT_JVMCFG_SRC in the open file - which makes more sense for the clean up. I was unsure if $(wildcard xxx) would behave