Good point, I will fix that.
/Erik
On 2015-04-15 22:01, David Katleman wrote:
The doc change is fine.
You need a corresponding autoconf update to verify that 4.0 or later
is being used on windows builds, to prevent cryptic errors like Phil
was running into.
The windows build should fail in
On 2015-04-15 11:24, Erik Joelsson wrote:
The macro SetupNativeCompilation handles various overrides of the
compiler and linker used for compilation. There is also a LANG option,
which implies that it needs to be told if it's compiling C or C++ when
in reality, this is handled automatically. Th
Looks ok to me.
/Erik
On 2015-04-16 01:50, joe darcy wrote:
Hello,
Please review the patch below to enable doclint checking on more
modules in the JDK 9 build:
JDK-8077912: Turn on doclint checking for more modules
http://cr.openjdk.java.net/~darcy/8077912.0/
(Some doclint cleanup
On 2015-04-16 01:50, joe darcy wrote:
Hello,
Please review the patch below to enable doclint checking on more
modules in the JDK 9 build:
JDK-8077912: Turn on doclint checking for more modules
http://cr.openjdk.java.net/~darcy/8077912.0/
(Some doclint cleanup is needed on java.manage
On 2015-04-15 01:44, David Katleman wrote:
We went through this exercise in January.
RE intentionally uses what is the documented minimum gnumake (3.81),
to verify that builds work with the oldest supported gnumake.
On 2015/1/31 4:01, David Katleman wrote:
You need to revert your 4.0 change
On 2015-04-15 09:41, Erik Joelsson wrote:
Please review this change to README-builds.html. I have updated all
references to the GNU make version to specify that we recommend 4.0 or
later on Windows. Cygwin has been shipping with 4.x for a long time
now and we have been using it internally since
On 2015-04-16 11:05, Magnus Ihse Bursie wrote:
On 2015-04-15 09:41, Erik Joelsson wrote:
Please review this change to README-builds.html. I have updated all
references to the GNU make version to specify that we recommend 4.0
or later on Windows. Cygwin has been shipping with 4.x for a long
ti
Looks good to me.
/Erik
On 2015-04-15 15:12, Magnus Ihse Bursie wrote:
On windows, many executables have an assembly manifest embedded. This
sets among other things the JDK version. Our current handling of this
is sub-optimal, using template files that are modified at build time.
Instead, a c
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8077824/webrev.root.02/
On 2015-04-16 10:42, Magnus Ihse Bursie wrote:
In general, I'm very happy with this. It's a nice encapsulation!
Thanks!
However, I do have a bunch of issues/questions:
* AR is missing from the documentation of Def
Here is a webrev including a configure check.
http://cr.openjdk.java.net/~erikj/8072023/webrev.01/
/Erik
On 2015-04-16 10:41, Erik Joelsson wrote:
Good point, I will fix that.
/Erik
On 2015-04-15 22:01, David Katleman wrote:
The doc change is fine.
You need a corresponding autoconf update
On 2015-04-16 12:01, Erik Joelsson wrote:
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8077824/webrev.root.02/
Looks good to me now! Just one typo: "assignements", no need to respin
the webrev for that.
* BUILD_LIBJAWT seems to have lost a LANG := C++ but not gained a
TOOLCHAIN
On 2015-04-16 12:42, Erik Joelsson wrote:
Here is a webrev including a configure check.
http://cr.openjdk.java.net/~erikj/8072023/webrev.01/
Looks good to me.
/Magnus
On 2015-04-16 11:29, Erik Joelsson wrote:
On 2015-04-16 11:05, Magnus Ihse Bursie wrote:
Am I just a backwards old-timer if I think we should still support
3.81? It's one thing to recommend 4.x to users, I'll agree with that
anytime, but should we require 4.0 by a check in configure, or a
war
Hi David,
Thanks for your response! I was using GCC as I had a host of other errors
when using clang :-|. I'll post those in a separate mail for comparison.
Cheers,
Martijn
On 15 April 2015 at 18:22, David DeHaven wrote:
>
> > Mac OS X 10.10.3, latest Xcode (6.3), using GCC 4.8
> >
> > -
Joe:
On 2015-04-16 01:50, joe darcy wrote:
Hello,
Please review the patch below to enable doclint checking on more
modules in the JDK 9 build:
JDK-8077912: Turn on doclint checking for more modules
http://cr.openjdk.java.net/~darcy/8077912.0/
(Some doclint cleanup is needed on jav
> What makes java.xml.bind so special that make 3.81 should barf on it,
but no other modules?
Nothing that I can see. Its very strange.
-phil.
On 04/16/2015 02:02 AM, Magnus Ihse Bursie wrote:
On 2015-04-15 01:44, David Katleman wrote:
We went through this exercise in January.
RE intentiona
Erik:
New webrev: http://cr.openjdk.java.net/~erikj/8077824/webrev.root.02/
On 2015-04-16 10:42, Magnus Ihse Bursie wrote:
In general, I'm very happy with this. It's a nice encapsulation!
Thanks!
However, I do have a bunch of issues/questions:
* AR is missing from the documentation of Def
PS Some doclint fixes in additional modules came in and Tim did an
off-list review to add in the new modules to the list.
Thanks,
-Joe
On 4/16/2015 7:46 AM, Tim Bell wrote:
Joe:
On 2015-04-16 01:50, joe darcy wrote:
Hello,
Please review the patch below to enable doclint checking on more
Sorry, I've had my blinders on for a few weeks. What's the original goal here?
Are you just trying to build OpenJDK 9 on Mac OS X? If you're using clang in
Xcode then it should "just work".
-DrD-
> On Apr 16, 2015, at 6:35 AM, Martijn Verburg wrote:
>
> Hi David,
>
> Thanks for your response
It has happened again that a broken fix, for which there was a quick
follow up fix, has been pushed to the master without the follow up fix
going with it. So now everyone will potentially be impacted by the bad
fix as it propagates back down to all the forests :(
Bad fix:
https://bugs.openjdk
Hi David,
> We need something in place to ensure this doesn't happen!
We push to Master after team forests successfully go through the
following PIT steps:
- full build (hotspot ... install) for all 7 platforms
- fastdebug builds for all 7 platforms
- boot_cycle builds
- extended set of JPRT t
Hi Lana,
On 17/04/2015 2:28 PM, Lana Steuck wrote:
Hi David,
> We need something in place to ensure this doesn't happen!
We push to Master after team forests successfully go through the
following PIT steps:
- full build (hotspot ... install) for all 7 platforms
- fastdebug builds for all 7 pl
22 matches
Mail list logo
