RFR: 8066757 Can't build 'images' with --disable-zip-debug-info on OS X after jigsaw m2 merge

2015-04-24 Thread Staffan Larsen
Please review this fix for using --disable-zip-debug-info when compiling the images target. OS X stores symbol information in a .dylib file inside a .dSYM directory and that file should not be stripped, so this patch prunes the tree at the .dSYM directory. bug: https://bugs.openjdk.java.net/br

Re: RFR (XS) 8078404: VERBOSE make flag is not handled properly

2015-04-24 Thread Stanislav Baiduzhyi
On Thursday 23 April 2015 08:30:46 Erik Joelsson wrote: > Hello Stanislav, > > What do you want to achieve by setting VERBOSE=1? AFAIK that has never > been a valid value for the VERBOSE input variable. In jdk8, we initially > introduced VERBOSE as an input variable to the new build system. It was

Re: RFR: 8066757 Can't build 'images' with --disable-zip-debug-info on OS X after jigsaw m2 merge

2015-04-24 Thread Erik Joelsson
Looks good to me. /Erik On 2015-04-24 00:25, Staffan Larsen wrote: Please review this fix for using --disable-zip-debug-info when compiling the images target. OS X stores symbol information in a .dylib file inside a .dSYM directory and that file should not be stripped, so this patch prunes t

Re: Windows configure error : LZMAPATH

2015-04-24 Thread Sergey Bylokhov
Got the same issue when I try to build jdk8u-dev. But everything is ok in jdk9. On 18.03.2015 2:57, Phil Race wrote: I'll admit its been a few weeks since I've build JDK on Windows except via jprt but now I can't get past configure and I don't know why its resolving a variable that I didn't s

Re: RFR: JDK-8078437: Enable use of devkits for Windows

2015-04-24 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 23 apr 2015 kl. 18:42 skrev Erik Joelsson : > > Hello, > > Internally at Oracle, we have been using devkits for building on Linux and > Solaris. We would like to extend this to also work on Windows for our > internal build servers. Using a devkit simplifies build

Re: RFR: 8066757 Can't build 'images' with --disable-zip-debug-info on OS X after jigsaw m2 merge

2015-04-24 Thread Magnus Ihse Bursie
Looks good to me too. /Magnus > 24 apr 2015 kl. 17:21 skrev Erik Joelsson : > > Looks good to me. > > /Erik > >> On 2015-04-24 00:25, Staffan Larsen wrote: >> Please review this fix for using --disable-zip-debug-info when compiling the >> images target. >> >> OS X stores symbol information

Re: Windows configure error : LZMAPATH

2015-04-24 Thread alexey menkov
lzma is required for installer. You can get it from /java/devtools/windows/bin/ (I suppose both lzma.exe & lzma.dll are required) regards Alex On 24.04.2015 19:56, Sergey Bylokhov wrote: Got the same issue when I try to build jdk8u-dev. But everything is ok in jdk9. On 18.03.2015 2:57, Phil Ra