RFR: JDK-8079771 Fix SoundLibraries.gmk mismerge after JDK-8072665

2015-05-08 Thread Magnus Ihse Bursie
The merge changeset c892d81d7bba unfortunately re-introduced the X_ARCH define for aarch64, even though JDK-8072665 had removed it. Bug: https://bugs.openjdk.java.net/browse/JDK-8079771 WebRev inline: diff --git a/make/lib/SoundLibraries.gmk b/make/lib/SoundLibraries.gmk --- a/make/lib/SoundLib

Re: RFR: JDK-8079771 Fix SoundLibraries.gmk mismerge after JDK-8072665

2015-05-08 Thread David Holmes
Hi Magnus, On 8/05/2015 5:18 PM, Magnus Ihse Bursie wrote: The merge changeset c892d81d7bba unfortunately re-introduced the X_ARCH define for aarch64, even though JDK-8072665 had removed it. Bug: https://bugs.openjdk.java.net/browse/JDK-8079771 WebRev inline: diff --git a/make/lib/SoundLibrari

Re: RFR: JDK-8079771 Fix SoundLibraries.gmk mismerge after JDK-8072665

2015-05-08 Thread Erik Joelsson
With Davids addition, this looks good to me. /Erik On 2015-05-08 09:34, David Holmes wrote: Hi Magnus, On 8/05/2015 5:18 PM, Magnus Ihse Bursie wrote: The merge changeset c892d81d7bba unfortunately re-introduced the X_ARCH define for aarch64, even though JDK-8072665 had removed it. Bug: http

Re: RFR: JDK-8079771 Fix SoundLibraries.gmk mismerge after JDK-8072665

2015-05-08 Thread Magnus Ihse Bursie
On 2015-05-08 09:34, David Holmes wrote: Hi Magnus, On 8/05/2015 5:18 PM, Magnus Ihse Bursie wrote: The merge changeset c892d81d7bba unfortunately re-introduced the X_ARCH define for aarch64, even though JDK-8072665 had removed it. Bug: https://bugs.openjdk.java.net/browse/JDK-8079771 WebRev i

Re: RFR: JDK-8074859 Turn on warnings as error

2015-05-08 Thread Magnus Ihse Bursie
On 2015-04-20 09:02, Erik Joelsson wrote: Looks good to me. Thanks Erik. Unfortunately, I never got round to pushing this. In the meantime, the codebase evolved, and I had to add a couple of more disabled warnings. I also modified the help text on a failed build slightly. Here's the updated

Re: RFR: JDK-8074859 Turn on warnings as error

2015-05-08 Thread Erik Joelsson
Looks good. /Erik On 2015-05-08 09:57, Magnus Ihse Bursie wrote: On 2015-04-20 09:02, Erik Joelsson wrote: Looks good to me. Thanks Erik. Unfortunately, I never got round to pushing this. In the meantime, the codebase evolved, and I had to add a couple of more disabled warnings. I also mod

Re: Backport multiple toolchains support to JDK8?

2015-05-08 Thread Magnus Ihse Bursie
On 2015-05-08 04:46, Alexander Smundak wrote: I have backported "8034788: Rewrite toolchain.m4 to support multiple toolchains per platform." and related changes to jdk8u40 in order to build JDK8 with Clang/LLVM on Linux. Can I mail this change for the review? JDK 8u40 is already released. Did y

Re: RFR: JDK-8074859 Turn on warnings as error

2015-05-08 Thread Tim Bell
Magnus: Looks good to me as well. Tim On 05/08/15 01:32, Erik Joelsson wrote: Looks good. /Erik On 2015-05-08 09:57, Magnus Ihse Bursie wrote: On 2015-04-20 09:02, Erik Joelsson wrote: Looks good to me. Thanks Erik. Unfortunately, I never got round to pushing this. In the meantime, the