Re: [8u60] Request for review and approval: JDK-8074523: Windows native binaries have inconsistent "Product version"

2015-05-26 Thread Erik Joelsson
Any chance I could get a review on this? /Erik On 2015-05-20 16:09, Erik Joelsson wrote: Thanks, changed to: Windows native binaries have inconsistent "Product version" Changed the label. /Erik On 2015-05-20 14:49, Seán Coffey wrote: It might be good to edit the bug synopsis before pushing

Re: RfR JDK-8077296 RE build fails on non-Win builds when attempting to build Win only javadoc

2015-05-26 Thread Phil Race
+1 -phil. On 05/21/2015 12:11 AM, Erik Joelsson wrote: Hello Pete, This looks good to me. /Erik On 2015-05-21 07:33, Pete Brunet wrote: Please review the following change for 8u: http://cr.openjdk.java.net/~ptbrunet/JDK-8077296/webrev.00/ Background: - As part of the open sourcing of the

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

2015-05-26 Thread Roger Riggs
Hi, Sadly, but not entirely unexpectedly there is an anomaly in the include files: It seems that Windows does not define O_SYNC and O_DSYNC. To make up for the absence jdk/src/java.base/share/native/libjava/io_util.h conditionally defines them. There is no problem if the system include files