Re: RFR 7191662: JCE providers should be located via ServiceLoader

On 16/06/2015 00:58, Valerie Peng wrote: It seems that the jimage refresh change may still take some time, so we will end up removing the makefile related changes and then deferring the ServiceLoader related changes to Jake workspace. Here is the latest webrev (Security source/test changes o

Re: JDK 9 RFR of JDK-8098579: Remove non-existent javax.tools.annotation package from CORE_PKGS.gmk

Hello Joe, Looks good to me. /Erik On 2015-06-15 19:13, joe darcy wrote: Hello, Please review the fix below to address JDK-8098579: Remove non-existent javax.tools.annotation package from CORE_PKGS.gmk Thanks, -Joe diff -r 1bcfd6b87265 make/common/CORE_PKGS.gmk --- a/make/common/CO

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

Hello Roger, Build change looks fine to me. /Erik On 2015-06-15 23:58, Roger Riggs wrote: Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses the same technique used by Hotspot in src/os/windows/vm/os

Error: SPEC mismatch! Current working directory does not match either TOPDIR, ORIGINAL_TOPDIR or CANONICAL_TOPDIR

Hi all, Sitting in the build OpenJDK workshop at Devoxx UK and I have the following issue on Mac OS X (building jdk9). Error: SPEC mismatch! Current working directory /Users/karianna/Documents/workspace/AdoptOpenJDK_Projects/jdk9 --- Seems to be related to: http://hg.openjdk.java.net/jdk9/j

Re: Error: SPEC mismatch! Current working directory does not match either TOPDIR, ORIGINAL_TOPDIR or CANONICAL_TOPDIR

Hello Martijn, I believe this is a problem of string comparisons of file paths and character case. The file system on Macosx is case insensitive, but we aren't treating it as such properly. The difference is in the 'p' in 'project' in the directory name 'AdoptOpenJDK_projects'. The directory

Re: Error: SPEC mismatch! Current working directory does not match either TOPDIR, ORIGINAL_TOPDIR or CANONICAL_TOPDIR

Hi Erik, Thanks, renaming the directory to match the casing got me past that step. I'm on the next issue now, I'll post with a separate subject. Cheers, Martijn On 17 June 2015 at 11:28, Erik Joelsson wrote: > Hello Martijn, > > I believe this is a problem of string comparisons of file paths a

Mac OS X - error: out-of-line definition of 'getenv' does not match any declaration in 'os' in os_bsd.cpp

Hi all, Building jdk9 on latest Mac OS X, XCode/Clang etc. Not sure if the Mac OS X build still needs to rely on BSD as such I'll dig further but figured it was worth reporting the initial error. --- Note: Recompile with -Xlint:unchecked for details. /Users/karianna/Documents/workspace

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

On 15/06/2015 22:58, Roger Riggs wrote: Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses the same technique used by Hotspot in src/os/windows/vm/os_windows.cpp. The Windows link of CoreLibraries.gmk

Re: Mac OS X - error: out-of-line definition of 'getenv' does not match any declaration in 'os' in os_bsd.cpp

On 17/06/2015 9:06 PM, Martijn Verburg wrote: Hi all, Building jdk9 on latest Mac OS X, XCode/Clang etc. Not sure if the Mac OS X build still needs to rely on BSD as such I'll dig further but figured it was worth reporting the initial error. --- Note: Recompile with -Xlint:unchecked

Re: Mac OS X - error: out-of-line definition of 'getenv' does not match any declaration in 'os' in os_bsd.cpp

Hi David, My bad, I was using http://hg.openjdk.java.net/jdk9/dev as opposed to http://hg.openjdk.java.net/jdk9/jdk9 - of course this leads to my third build issue which I'll post about with a separate title. Apologies all, I appreciate it's painful to deal with the endless queries on my part, ple

Build success!

Hi all, In an attempt to be the most annoying person on build-dev in June (do you hand out prizes, because I'm totally winning). I'm now at the "error: comparison of array 'rasterP->sppsm.offsets' not equal to a null pointer is always true" bug aka https://bugs.openjdk.java.net/browse/JDK-8080993

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

Hi Alan, Would there be any concerns about backporting to JDK 8? On 6/17/2015 7:32 AM, Alan Bateman wrote: On 15/06/2015 22:58, Roger Riggs wrote: Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses the

Re: RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

On 17/06/2015 14:49, Roger Riggs wrote: Hi Alan, Would there be any concerns about backporting to JDK 8? I don't think so but it will require the jdk8u maintainers to approve. The new helper APIs only veri