Hello Henry,
Build changes look good to me.
/Erik
On 2015-07-10 05:48, Henry Jen wrote:
Hi,
Please review proposed patch for JDK-8027634[1]. This patch is to enable java
support command line argument file like javac does. The implementation use the
same syntax rule, which is implemented in
Hello Henry,
Unfortunatey --disable-warnings-as-errors does not apply to the Hotspot
build. I think you can disable them by setting WARNINGS_ARE_ERRORS= on
the make command line.
/Erik
On 2015-08-07 20:52, Henry Jen wrote:
Hi,
I am seeing following building errors on Traditional Chinese Wi
Hello Valerie,
To reduce duplication, I think something like this would be preferable.
Remove the windows and macosx checks and just always run this line:
POLICY_SRC_LIST += \
$(wildcard
$(JDK_TOPDIR)/src/java.base/$(OPENJDK_TARGET_OS)/conf/security/java.policy)
That way, I platform spe
Looks good to me.
/Erik
On 2015-08-07 08:57, Staffan Larsen wrote:
Please review the following changes to remove the hprof JVMTI agent. There are
changes in three different repositories. All tests that used the hprof agent
has been removed in previous changesets.
Note: This does not remove t
New build changes look fine to me.
/Erik
On 2015-08-08 09:03, Henry Jen wrote:
Hi,
Another update for argument file support, this version we added a couple
measures to ensure compatibility,
1) Compile time directive ENABLE_ARG_FILES is needed to enable the feature,
only java is enabled with
Thanks Erik!
> On 10 aug 2015, at 12:52, Erik Joelsson wrote:
>
> Looks good to me.
>
> /Erik
>
> On 2015-08-07 08:57, Staffan Larsen wrote:
>> Please review the following changes to remove the hprof JVMTI agent. There
>> are changes in three different repositories. All tests that used the hp
