Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

Build changes look good. /Erik On 2015-08-14 04:31, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider is separated out from the "osx" one generated in jdk.dep

Fwd: cygwin too old ?

Can any one assist ? Please ? -- Forwarded message - From: Boaz Nahum Date: Sun, Aug 9, 2015 at 9:12 PM Subject: cygwin too old ? To: build-dev-requ...@openjdk.java.net I got this error message when trying to build http://hg.openjdk.java.net/valhalla/valhalla configure: Your c

Re: Fwd: cygwin too old ?

Hi Boaz, Your problem looks like JDK-8079087 , which has been fixed in jdk9/dev. Maybe the Valhalla project needs to sync. /ingo On 2015-08-14 10:41, Boaz Nahum wrote: Can any one assist ? Please ? -- Forwarded message - Fro

Re: Fwd: cygwin too old ?

Many thanks Whom should I asked to do this sync? Boaz On Fri, Aug 14, 2015 at 12:12 PM Ingemar Åberg wrote: > Hi Boaz, > > Your problem looks like JDK-8079087 > , which has been fixed > in jdk9/dev. Maybe the Valhalla project needs to sync. >

Re: Fwd: cygwin too old ?

I've pushed a temp workaround for this; let me know if it works for you. Maurizio On 14/08/15 11:07, Boaz Nahum wrote: Many thanks Whom should I asked to do this sync? Boaz On Fri, Aug 14, 2015 at 12:12 PM Ingemar Åberg wrote: Hi Boaz, Your problem looks like JDK-8079087

Re: Fwd: cygwin too old ?

Thx now I have valhalla on my win 10 :) One more little sync request src/share/vm/classfile/systemDictionary.cpp contains error: - return (strstr(str, str_to_find)); Should be + return (strstr(str, str_to_find)) != NULL; It was fixed on jdk9dev Can I asked for this sync too ? Boaz On F

Re: Fwd: cygwin too old ?

Is this only an error with Windows build? Maurizio On 14/08/15 12:43, Boaz Nahum wrote: Thx now I have valhalla on my win 10 :) One more little sync request src/share/vm/classfile/systemDictionary.cpp contains error: - return (strstr(str, str_to_find)); Should be + return (strstr(str,

Re: Fwd: cygwin too old ?

YES !!! On Fri, Aug 14, 2015 at 3:08 PM Maurizio Cimadamore < maurizio.cimadam...@oracle.com> wrote: > Is this only an error with Windows build? > > Maurizio > > On 14/08/15 12:43, Boaz Nahum wrote: > > Thx now I have valhalla on my win 10 :) > > > > One more little sync request > > > > src/sha

Re: Fwd: cygwin too old ?

Ok - got it; the original comment that this was fixed in 9 got me off track; the code in question is new in Valhalla repo, so there's no JDK 9 equivalent for it. It's just a bug/glitch in the following hostpot patch: http://hg.openjdk.java.net/valhalla/valhalla/hotspot/rev/419818b23594 Fixed n

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

Couple of minor comments on ProviderConfig.java 183: you can use the diamond operator for anonymous classes now (PrivilegedAction<>). You could also use a lambda expression here but I'll leave that up to you. 193: the braces around "if (debug != null)" are not indented properly Looks fine ot

Re: Fwd: cygwin too old ?

Now it works Thx boaz On Fri, Aug 14, 2015 at 3:52 PM Maurizio Cimadamore < maurizio.cimadam...@oracle.com> wrote: > Ok - got it; the original comment that this was fixed in 9 got me off > track; the code in question is new in Valhalla repo, so there's no JDK 9 > equivalent for it. It's just a

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

> On Aug 13, 2015, at 7:31 PM, Valerie Peng wrote: > > > Can someone please help reviewing this change? > This is to move Apple provider from jdk.deploy.osx module to java.base module. > The native library for Apple provider is separated out from the "osx" one > generated in jdk.deploy.osx mod

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

Updated the webrev in place to use "osxsecurity" given peer feedbacks. Thanks, Valerie On 8/13/2015 7:31 PM, Valerie Peng wrote: Can someone please help reviewing this change? This is to move Apple provider from jdk.deploy.osx module to java.base module. The native library for Apple provider

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

Looks good. Mandy > On Aug 14, 2015, at 4:30 PM, Valerie Peng wrote: > > > Updated the webrev in place to use "osxsecurity" given peer feedbacks. > Thanks, > Valerie > > On 8/13/2015 7:31 PM, Valerie Peng wrote: >> >> Can someone please help reviewing this change? >> This is to move Apple pro