Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-18 Thread Erik Joelsson
One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM, Valerie Peng wrote: Updated the webrev in place to use "osxse

Re: JDK-8061281 (JEP-230): Push Makefiles, repository layout and small set of benchmarks

2015-08-18 Thread Magnus Ihse Bursie
On 2015-08-13 00:24, Staffan Friberg wrote: Hi Erik, Thank you for the quick review. I have fixed all your comments in this new webrev, http://cr.openjdk.java.net/~sfriberg/JDK-8061281/webrev.02 Looks good to me! /Magnus Cheers, Staffan On 08/12/2015 03:15 AM, Erik Joelsson wrote: Hello,

Re: RFR JDK-8129562: JDK 9 build using boot-jdk classes instead of newly compiled classes

2015-08-18 Thread Magnus Ihse Bursie
On 2015-08-06 19:08, Jan Lahoda wrote: Jon suggested that now, when the EMPTY_BOOTCLASSPATH is used not only for -bootclasspath, it could be renamed to EMPTY_DIR. An updated webrev with the rename is here: http://cr.openjdk.java.net/~jlahoda/8129562/webrev.01/ How does this look? Looks fine

Re: [9] RFR 8086002: Move apple.security.AppleProvider to a proper module

2015-08-18 Thread Valerie Peng
Ok, thanks! Valerie On 8/18/2015 12:34 AM, Erik Joelsson wrote: One is enough. /Erik On 2015-08-18 02:21, Valerie Peng wrote: Thanks for the review. Is one more reviewer from build team needed? Valerie On 8/14/2015 4:58 PM, Mandy Chung wrote: Looks good. Mandy On Aug 14, 2015, at 4:30 PM,