Re: RFR (S): 8140091: remove VMStructs cast_uint64_t workaround for GCC 4.1.1 bug

2015-10-22 Thread Erik Joelsson
I think this is ok, but we should make sure to add a check in configure in the hotspot build-infra project. /Erik On 2015-10-21 21:46, Christian Thalinger wrote: https://bugs.openjdk.java.net/browse/JDK-8140091 http://cr.openjdk.java.net/~twisti/8140091/webrev/ There is a bit more context in

Re: [patch] fix the build with a toolchain with a linker defaulting to ld --as-needed

2015-10-22 Thread Magnus Ihse Bursie
On 2015-10-20 10:28, Erik Joelsson wrote: Hello Matthias, I think this looks good and can sponsor the push for you. Have you signed the OCA? The patch looks good to me to. /Magnus /Erik On 2015-10-19 22:06, Matthias Klose wrote: Toolchains for some Linux distributions (e.g. Ubuntu, OpenSu

RFR: JDK-8140312: Enable new sjavac server only mode in jdk build

2015-10-22 Thread Erik Joelsson
In JDK-8135131, sjavac added a thin server mode, in which only the server part of sjavac is used for running plain javac. This patch adds a configure option to enable this mode of running to the jdk build. Later, if it seems to work well, we will consider making it default. On my workstation (

Re: RFR: JDK-8140277 Configuration out-of-date check should also check closed sources

2015-10-22 Thread Erik Joelsson
Looks good to me. /Erik On 2015-10-21 23:56, Magnus Ihse Bursie wrote: In Init.gmk, there is a check if the configure source code has changes. If so, the configuration is out of date and not usable. This check should be extended to the closed configuration sources (if present), not only open

Re: RFR: JDK-8140282 Remove test directories on clean-test-*

2015-10-22 Thread Erik Joelsson
Looks good to me. /Erik On 2015-10-22 01:56, Magnus Ihse Bursie wrote: Using some makefile magic, we transform clean-test-foo-bar-baz into a call to "rm -r $b/support/test/foo/bar/baz". However, this might leave a chain of empty directories $b/support/test/foo/bar, which is not so nice. We s

Re: RFR (S): 8140091: remove VMStructs cast_uint64_t workaround for GCC 4.1.1 bug

2015-10-22 Thread Christian Thalinger
> On Oct 21, 2015, at 10:57 PM, Erik Joelsson wrote: > > I think this is ok, but we should make sure to add a check in configure in > the hotspot build-infra project. Yes, we should do that. I was looking for something like this but couldn’t find any code so I went ahead and did it in the Ho

Re: RFR (S): 8140091: remove VMStructs cast_uint64_t workaround for GCC 4.1.1 bug

2015-10-22 Thread Vladimir Kozlov
Hotspot changes looks fine. I was surprise that code was added long ago. Thanks, Vladimir On 10/22/15 3:46 AM, Christian Thalinger wrote: https://bugs.openjdk.java.net/browse/JDK-8140091 http://cr.openjdk.java.net/~twisti/8140091/webrev/ There is a bit more context in JIRA but the bottom line