Re: hardcoding -m32/-m64 is more harmful than using the toolchain defaults

2015-10-29 Thread Andrew Haley
On 28/10/15 18:50, Martin Buchholz wrote: > I'll buy that - it's an "easy" job, but still a job for a compiler writer. > > Perhaps x32 has less benefit for java programs because jits are already > free to generate code that uses 32-bit pointers but takes advantage of the > x86_64 instruction set?

RFR: JDK-8140762 Specifying --without-LIB if not needed should not result in warning

2015-10-29 Thread Magnus Ihse Bursie
If we specify e.g. --without-cups on a platform where cups is neither needed nor used, we will get a warning that --with-cups is ignored. In fact, specifying --without-X when X is not needed is the default and it should just be silently skipped by. Bug: https://bugs.openjdk.java.net/browse/JDK

JDK9: Build wb.jar which depends on JDK9 API

2015-10-29 Thread Vladimir Ivanov
Hi, Quick question: I have to use Java9 API in sun.misc.WhiteBox, but right now it is built using BOOT_JDK. Does the following change [1] look good? The following dependency seems too conservative (depends on hotspot which is not necessary): build-test-lib: $(JAVA_TARGETS) but I haven't

Re: RFR: JDK-8140661 Rename LDFLAGS_SUFFIX to LIBS

2015-10-29 Thread Erik Joelsson
Looks good to me. /Erik On 2015-10-28 22:03, Magnus Ihse Bursie wrote: The build system has not been good at separating LIBS from LDFLAGS. In fact, when we started doing this, the name "LDFLAGS_SUFFIX" was used for what is traditionally called LIBS. This unwieldy name has unfortunately been k

Re: RFR: JDK-8140762 Specifying --without-LIB if not needed should not result in warning

2015-10-29 Thread Erik Joelsson
Looks good to me. /Erik On 2015-10-29 11:39, Magnus Ihse Bursie wrote: If we specify e.g. --without-cups on a platform where cups is neither needed nor used, we will get a warning that --with-cups is ignored. In fact, specifying --without-X when X is not needed is the default and it should ju

Re: JDK9: Build wb.jar which depends on JDK9 API

2015-10-29 Thread Erik Joelsson
Hello, On 2015-10-29 14:43, Vladimir Ivanov wrote: Hi, Quick question: I have to use Java9 API in sun.misc.WhiteBox, but right now it is built using BOOT_JDK. Does the following change [1] look good? The changes look ok, but may impact build times as the building of tests will have to wait

Re: RFR: JDK-8140591: Add configure argument specifying make executable in JPRT

2015-10-29 Thread Tim Bell
Erik: Looks good to me as well. Tim On 10/28/15 04:09, Magnus Ihse Bursie wrote: Looks good to me. Nice solution in basics.m4! /Magnus 28 okt. 2015 kl. 10:47 skrev Erik Joelsson : I've noticed that on some linux systems (maybe even all OEL6 and 7), there is a /usr/bin/gmake binary. Confi