Looks good to me.
/Erik
On 2015-11-10 03:56, Ioi Lam wrote:
Please review a very very small fix:
http://cr.openjdk.java.net/~iklam/8080940-remove-solaris-mcs/
Bug: 8080940 Remove mcs post-hook from hotspot solaris builds
https://bugs.openjdk.java.net/browse/JDK-8080940
Summary of fix:
On 2015-11-10 09:52, Erik Joelsson wrote:
On 2015-11-09 11:09, Magnus Ihse Bursie wrote:
The new COMPARE_BUILD feature has proven valuable to build system
development. However, after use it leaves the build system in a
different state than prior to use, which requires manual intervention
for
Looks good.
/Erik
On 2015-11-10 11:19, Magnus Ihse Bursie wrote:
On 2015-11-10 09:52, Erik Joelsson wrote:
On 2015-11-09 11:09, Magnus Ihse Bursie wrote:
The new COMPARE_BUILD feature has proven valuable to build system
development. However, after use it leaves the build system in a
differ
On 2015-11-09 11:09, Magnus Ihse Bursie wrote:
The new COMPARE_BUILD feature has proven valuable to build system
development. However, after use it leaves the build system in a
different state than prior to use, which requires manual intervention
for multiple runs.
This patch fixes so that
Looks even better.
/Erik
On 2015-11-10 02:46, Bhavesh Patel wrote:
Hi,
Jonathan Gibbons mentioned that the top level make/CompileJavaModules.gmk
also need to be modified for this fix. Thanks Jon. I made the change Jon has
suggested and the updated webrev can be found at
http://cr.openjdk
Looks good to me.
/Erik
On 2015-11-10 01:28, Bhavesh Patel wrote:
Hi,
As a part of javdoc search feature for JDK 9 (JEP 225. JIRA:
https://bugs.openjdk.java.net/browse/JDK-8142367), javadoc would need to copy
files with .png extension to the generated output folder. the
langtools/make/Com
The macro for SetupCompileProperties in jdk is not using the named
arguments call style. We should fix that.
Bug: https://bugs.openjdk.java.net/browse/JDK-8142383
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8142383-fix-SetupCompileProperties/webrev.01
/Magnus
Oops, this was sent to the wrong mailing list, please ignore.
/Erik
On 2015-11-09 19:33, Erik Joelsson wrote:
Closed part of this review.
Bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8142336
Webrev with both open and closed changes:
http://javaweb.us.oracle.com/~ejoelsso/webrev/8142336/w
On 2015-11-10 03:56, Ioi Lam wrote:
Please review a very very small fix:
http://cr.openjdk.java.net/~iklam/8080940-remove-solaris-mcs/
Looks good to me.
/Magnus
Bug: 8080940 Remove mcs post-hook from hotspot solaris builds
https://bugs.openjdk.java.net/browse/JDK-8080940
Summary of fix:
On 2015-11-09 19:33, Erik Joelsson wrote:
Hello,
As a stepping stone in the hotspot makefile conversion, I have broken
out the serviceability agent separately and converted it into proper
modular build-infra makefiles. Doing this conversion separately has
some value on its own by reducing the
On 2015-11-10 02:46, Bhavesh Patel wrote:
Hi,
Jonathan Gibbons mentioned that the top level make/CompileJavaModules.gmk
also need to be modified for this fix. Thanks Jon. I made the change Jon has
suggested and the updated webrev can be found at
http://cr.openjdk.java.net/~bpatel/8142367/w
Looks good.
/Erik
On 2015-11-10 10:24, Magnus Ihse Bursie wrote:
The macro for SetupCompileProperties in jdk is not using the named
arguments call style. We should fix that.
Bug: https://bugs.openjdk.java.net/browse/JDK-8142383
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8142383-fix-SetupCo
On 2015-11-10 11:39, Magnus Ihse Bursie wrote:
On 2015-11-09 19:33, Erik Joelsson wrote:
Hello,
As a stepping stone in the hotspot makefile conversion, I have broken
out the serviceability agent separately and converted it into proper
modular build-infra makefiles. Doing this conversion separ
Hi Magnus,
Yes. I have verified it and the .png files get copied over to the
output folder generated by javadoc as expected.
Regards,
Bhavesh.
- Original Message -
From: magnus.ihse.bur...@oracle.com
To: bhavesh.x.pa...@oracle.com, build-dev@openjdk.java.net
Sent: Tuesday, No
14 matches
Mail list logo
