Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread Thomas Stüfe
Thank you, Eric! On Thu, Dec 17, 2015 at 8:58 AM, Erik Joelsson wrote: > I only got a bug report for Linux and can't test AIX. A quick look at the > makefiles for AIX, I think you are probably fine. At least the weird > construct in the Linux makefiles is not there to mess things up. > > /Erik >

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread David Holmes
On 17/12/2015 5:54 PM, Erik Joelsson wrote: On 2015-12-17 01:40, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should this fix be pushed? Do you need it urgently in hs-rt? It is urgently needed in both the hs-rt and hs-comp repos as it affects nightly

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread Magnus Ihse Bursie
On 2015-12-17 09:08, David Holmes wrote: On 17/12/2015 5:54 PM, Erik Joelsson wrote: On 2015-12-17 01:40, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should this fix be pushed? Do you need it urgently in hs-rt? It is urgently needed in both the hs

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread Erik Joelsson
On 2015-12-17 09:08, David Holmes wrote: On 17/12/2015 5:54 PM, Erik Joelsson wrote: On 2015-12-17 01:40, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should this fix be pushed? Do you need it urgently in hs-rt? It is urgently needed in both the

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-17 Thread Gary Adams
I've revised the original webrev based on some feedback received. - reverted white space only changes - proper copyrights on the new files - some hotspot files contained previously removed code Webrev; http://cr.openjdk.java.net/~gadams/8145132/webrev.01/ Planning to push this first b

Re: RFR(XS) : 8144695 : --disable-warnings-as-errors does not work for HotSpot build

2015-12-17 Thread Igor Ignatyev
> On Dec 17, 2015, at 2:10 AM, Kim Barrett wrote: > > On Dec 16, 2015, at 5:54 PM, Igor Ignatyev wrote: >> >> as Mikael V correctly pointed out, there is missed $( ) in solaris/adlc. >> here is the new webrev: >> http://cr.openjdk.java.net/~iignatyev/8144695/webrev.01/ > > I wonder why the v

RFR: JDK-8145596 Enable debug symbols for all libraries

2015-12-17 Thread Magnus Ihse Bursie
For historical reasons, the FDS (Full Debug Symbols) project only enabled debug symbols for a few select libraries, since this was difficult to achieve in the old build. Also, the FDS project never enabled debug symbols for macosx on the JDK libraries. With the new build system, debug symbols

RFR: JDK-8145670: New Solaris devkits are missing gobjcopy

2015-12-17 Thread Erik Joelsson
Hello, Please review this minor update to the Solaris devkit which adds gobjcopy. New devkits have been built using this and are being deployed. Bug: https://bugs.openjdk.java.net/browse/JDK-8145670 Webrev: http://cr.openjdk.java.net/~erikj/8145670/webrev.01/ /Erik

Re: RFR: JDK-8145670: New Solaris devkits are missing gobjcopy

2015-12-17 Thread Magnus Ihse Bursie
On 2015-12-17 14:59, Erik Joelsson wrote: Hello, Please review this minor update to the Solaris devkit which adds gobjcopy. New devkits have been built using this and are being deployed. Bug: https://bugs.openjdk.java.net/browse/JDK-8145670 Webrev: http://cr.openjdk.java.net/~erikj/8145670/we

Re: RFR: JDK-8145596 Enable debug symbols for all libraries

2015-12-17 Thread Erik Joelsson
Looks good to me. Note that this patch will conflict with the quick fix I did in jdk9/hs, so you will need to either wait for my patch, push in a forest that has my patch, or make sure the integrator can handle it correctly. /Erik On 2015-12-17 14:43, Magnus Ihse Bursie wrote: For historical

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread Daniel D. Daugherty
DEBUG_BINARIES is one of those "hidden" HotSpot big hammers that only affects Linux (IIRC). Basically, many years ago someone got tired of trying to figure out how to get completely debuggable HotSpot build on Linux and this big hammer was dropped in. I could chase down who and when, but I don't t

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-17 Thread Magnus Ihse Bursie
On 2015-12-17 14:19, Gary Adams wrote: I've revised the original webrev based on some feedback received. - reverted white space only changes - proper copyrights on the new files - some hotspot files contained previously removed code Webrev; http://cr.openjdk.java.net/~gadams/8145132/w

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-17 Thread Bob Vandette
1. In make/bsd/makefiles/vm.make You commented out the libffi logic that we’ll need to Zero iOS ARM. I guess we could uncomment this with the push to add this support. 2. hotspot/src/share/vm/runtime/java.cpp You shouldn’t need this change. dll_lookup does the right thing for static builds no

Re: Building jdk9 on Windows x64 and Visual Studio 2015 Communityedition

2015-12-17 Thread Kumar Srinivasan
I am good with this change!. I would like the rest of the component teams to weigh in on the others. Thanks Kumar On 12/16/2015 12:18 PM, Magnus Ihse Bursie wrote: On 2015-12-16 16:33, Kumar Srinivasan wrote: Hello, http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-17 Thread Gary Adams
On 12/17/15 11:09, Magnus Ihse Bursie wrote: On 2015-12-17 14:19, Gary Adams wrote: I've revised the original webrev based on some feedback received. - reverted white space only changes - proper copyrights on the new files - some hotspot files contained previously removed code Webrev

Re: RFR(XS) : 8144695 : --disable-warnings-as-errors does not work for HotSpot build

2015-12-17 Thread Kim Barrett
On Dec 17, 2015, at 8:22 AM, Igor Ignatyev wrote: > > >> On Dec 17, 2015, at 2:10 AM, Kim Barrett wrote: >> make/solaris/makefiles/adlc.make >> 77 WARNINGS_ARE_ERRORS ?= -w -xwe >> >> I'm pretty sure "-w" is wrong here, and should be removed. > you are right, I made a typo, it was ‘+w’ befo

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread David Holmes
On 17/12/2015 6:18 PM, Magnus Ihse Bursie wrote: On 2015-12-17 09:08, David Holmes wrote: On 17/12/2015 5:54 PM, Erik Joelsson wrote: On 2015-12-17 01:40, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should this fix be pushed? Do you need it urgently

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread David Holmes
On 17/12/2015 7:24 PM, Erik Joelsson wrote: On 2015-12-17 09:08, David Holmes wrote: On 17/12/2015 5:54 PM, Erik Joelsson wrote: On 2015-12-17 01:40, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should this fix be pushed? Do you need it urgently in h

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-17 Thread David Holmes
On 18/12/2015 1:58 AM, Daniel D. Daugherty wrote: DEBUG_BINARIES is one of those "hidden" HotSpot big hammers that only affects Linux (IIRC). Basically, many years ago someone got tired of trying to figure out how to get completely debuggable HotSpot build on Linux and this big hammer was dropped

Re: Building jdk9 on Windows x64 and Visual Studio 2015 Communityedition

2015-12-17 Thread David Holmes
On 18/12/2015 3:28 AM, Kumar Srinivasan wrote: I am good with this change!. I would like the rest of the component teams to weigh in on the others. This needs to be sent to all the affected component teams, or even better split into three pieces: build, hotspot and JDK libs, and then sent.

Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

2015-12-17 Thread David Holmes
On 17/12/2015 7:41 AM, Martin Buchholz wrote: We can fix both JDK-6515172 and JDK-8144312 by doing the autconf detection of how to count the number of allowed processors, then actually measuring what's available during the build, and also fixing the hotspot implemementation of Runtime.availablePr