Re: Building jdk9 on Windows x64 and Visual Studio 2015 Communityedition

2015-12-18 Thread Magnus Ihse Bursie
On 2015-12-18 05:11, David Holmes wrote: On 18/12/2015 3:28 AM, Kumar Srinivasan wrote: I am good with this change!. I would like the rest of the component teams to weigh in on the others. This needs to be sent to all the affected component teams, or even better split into three pieces: buil

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-18 Thread Magnus Ihse Bursie
On 2015-12-16 14:50, Magnus Ihse Bursie wrote: There is an interest from the community to build OpenJDK using Visual Studio 2015 Community edition. This patch is provided by Timo Kinnunen . I am sponsoring this patch. The changes to the source code files are mostly casts to uintptr_t, but the

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-18 Thread Magnus Ihse Bursie
On 2015-12-17 22:24, David Holmes wrote: On 17/12/2015 6:18 PM, Magnus Ihse Bursie wrote: On 2015-12-17 09:08, David Holmes wrote: On 17/12/2015 5:54 PM, Erik Joelsson wrote: On 2015-12-17 01:40, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should t

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

2015-12-18 Thread Magnus Ihse Bursie
On 2015-12-17 22:32, David Holmes wrote: On 17/12/2015 7:24 PM, Erik Joelsson wrote: On 2015-12-17 09:08, David Holmes wrote: On 17/12/2015 5:54 PM, Erik Joelsson wrote: On 2015-12-17 01:40, David Holmes wrote: On 17/12/2015 7:35 AM, Erik Joelsson wrote: One more thing, where should this f

Re: Building jdk9 on Windows x64 and Visual Studio 2015 Communityedition

2015-12-18 Thread David Holmes
On 18/12/2015 10:37 PM, Magnus Ihse Bursie wrote: On 2015-12-18 05:11, David Holmes wrote: On 18/12/2015 3:28 AM, Kumar Srinivasan wrote: I am good with this change!. I would like the rest of the component teams to weigh in on the others. This needs to be sent to all the affected component t

Build failure on windows 'freetypeScaler.c'

2015-12-18 Thread Boaz Nahum
Hi Lately, I have this error: f:/Dev/JDKBuild/valhalla/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c(106) : error C2220: warning treated as error - no 'object' file generated f:/Dev/JDKBuild/valhalla/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c(106) : warn

Re: Build failure on windows 'freetypeScaler.c'

2015-12-18 Thread Magnus Ihse Bursie
On 2015-12-18 14:16, Boaz Nahum wrote: Hi Lately, I have this error: f:/Dev/JDKBuild/valhalla/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c(106) : error C2220: warning treated as error - no 'object' file generated f:/Dev/JDKBuild/valhalla/jdk/src/java.desktop/share/native/li

Re: RFR 4823133: RandomAccessFile.length() is not thread-safe

2015-12-18 Thread Magnus Ihse Bursie
On 2015-12-15 18:25, Martin Buchholz wrote: _FILE_OFFSET_BITS is generally an all-or-nothing thing, because it affects interoperability between translation units. It would be good to convert all of the JDK build to use -D_FILE_OFFSET_BITS=64, but that would be a big job. So traditionally the JD

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-18 Thread Wang Weijun
Hi Vinnie I take a look and it includes a change for src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the Java_sun_security_mscapi_KeyStore_getKeyLength() function. It seems there is no sun.security.mscapi.KeyStore#getKeyLength on the java side. Is the function useless now? T

Re: Build failure on windows 'freetypeScaler.c'

2015-12-18 Thread Maurizio Cimadamore
Fix pushed Maurizio On 18/12/15 13:16, Boaz Nahum wrote: Hi Lately, I have this error: f:/Dev/JDKBuild/valhalla/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c(106) : error C2220: warning treated as error - no 'object' file generated f:/Dev/JDKBuild/valhalla/jdk/src/java.des

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-18 Thread Gary Adams
On 12/18/15 07:34, Magnus Ihse Bursie wrote: On 2015-12-17 20:40, Gary Adams wrote: On 12/17/15 11:09, Magnus Ihse Bursie wrote: On 2015-12-17 14:19, Gary Adams wrote: I've revised the original webrev based on some feedback received. - reverted white space only changes - proper copyright

Follow up bugs from the initial review comments

2015-12-18 Thread Gary Adams
I deferred a number of changes in order to get the first set of sources out to the mobile/dev repos. Just so we don't lose sight of those changes, I've filed a few bugs that can be addressed independently going forward. JDK-8145802: CPPFLAGS sysroot support JDK-8145804: ARFLAGS versus AR_OUT_

Re: RFR 4823133: RandomAccessFile.length() is not thread-safe

2015-12-18 Thread Martin Buchholz
On Fri, Dec 18, 2015 at 5:35 AM, Magnus Ihse Bursie wrote: > On 2015-12-15 18:25, Martin Buchholz wrote: >> >> _FILE_OFFSET_BITS is generally an all-or-nothing thing, because it >> affects interoperability between translation units. It would be good >> to convert all of the JDK build to use -D_FI

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-18 Thread Thomas Stüfe
Hi Gary, In the Linux os layer - especially in os_linux.cpp - I see you have reintroduced old coding we just painstakingly removed because it was not needed for modern Linuxes anymore. For instance, coding dealing with old Linuxthreads (vs Nptl, which is ubiquitous nowadays) or workarounds for old

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-18 Thread Bob Vandette
I caught that and gave Gary an updated set of os_linux* files that hopefully corrected this. Here’s the updated changes that Gary just pushed today. http://hg.openjdk.java.net/mobile/dev/hotspot/rev/f1acc8fa34b8 Bob. > On Dec 18, 2015, at 4:11 PM, Thomas Stüfe wrote: > > Hi Gary, > > In th

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2015-12-18 Thread Kim Barrett
On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie wrote: > > There is an interest from the community to build OpenJDK using Visual Studio > 2015 Community edition. > > This patch is provided by Timo Kinnunen . I am > sponsoring this patch. > > The changes to the source code files are mostly c

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

2015-12-18 Thread Thomas Stüfe
Hi Bob and Gary, Thank you for correcting this! Respect also on this large porting effort, this looks like a lot of work and I am curious how this will turn out. I took a short look at your changes - especially the android-related changes - and have a number of further questions and suggestions