Hello Volker,
I believe this change in behavior was intended at the time. In an
internal situation where the same thing hit us, we changed the exclude
pattern in question by adding a slash at the front: '/NativeThread.c'.
I should also inform you that I'm currently working on a major overhaul
On 2016-01-05 09:51, Erik Joelsson wrote:
Hello Volker,
I believe this change in behavior was intended at the time. In an
internal situation where the same thing hit us, we changed the exclude
pattern in question by adding a slash at the front: '/NativeThread.c'.
And the reason we needed t
Hello,
During the hotspot makefile conversion, we have been reminded of
inefficiencies when running make in Cygwin. We still have a pretty
severe performance regression in the new hotspot build compared to the
old on Windows in certain situations, my laptop being one such
situation. A recent
(not a review)
Thanks a bunch Erik for taking this on, +1.
The Cygwin abstraction layer is just painfully slow - as you point out, it has
to do with spawning new process all the time (where the Windows architecture
expects fat processes using many threads instead of short lived Posix
processes
I see, but as far as I understand all you are saying only applies to
the new hotspot-build system in build-infra. So I really don't see why
these changes had to be integrated into jdk9-dev. As far as I can see,
EXCLUDE_PATTERNS isn't currently used anywhere in jdk9-dev.
And I'm a little reluctant
Hello Volker,
On 2016-01-05 14:27, Volker Simonis wrote:
I see, but as far as I understand all you are saying only applies to
the new hotspot-build system in build-infra. So I really don't see why
these changes had to be integrated into jdk9-dev. As far as I can see,
EXCLUDE_PATTERNS isn't curre
OK, I only want to get this fixed now.
Do you agree with the new fix which is AIX-only and prepends '/' to
the filename as suggested by you:
http://cr.openjdk.java.net/~simonis/webrevs/2016/8146425.v1/
Regards,
Volker
On Tue, Jan 5, 2016 at 5:47 PM, Erik Joelsson wrote:
> Hello Volker,
>
> On
Looks good to me. Thank you Volker!
I will make sure I don't break this with the upcoming changes.
/Erik
On 2016-01-05 18:42, Volker Simonis wrote:
OK, I only want to get this fixed now.
Do you agree with the new fix which is AIX-only and prepends '/' to
the filename as suggested by you:
htt
Thanks for the fast review Erik.
I'll push it now and if I'm lucky enough I'll already fix our nightly
builds today :)
Regards,
Volker
On Tue, Jan 5, 2016 at 6:49 PM, Erik Joelsson wrote:
> Looks good to me. Thank you Volker!
>
> I will make sure I don't break this with the upcoming changes.
>
Erik:
During the hotspot makefile conversion, we have been reminded of
inefficiencies when running make in Cygwin.
[... snip ...]
Since these improvements affect much more than just the new hotspot
build, I intend to push this to JDK 9 directly.
Bug: https://bugs.openjdk.java.net/browse/
10 matches
Mail list logo
